Make lifecycle impl get_current_state() const. (ros2#2031)

We should only need to update the current state when it changes,
so we do that in the change_state method (which is not const).
Then we can just return the current_state_ object in
get_current_state, and then mark it as const.

Signed-off-by: Chris Lalancette <[email protected]>

Author: clalancette

rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_node.hpp

@@ -744,7 +744,7 @@ class LifecycleNode : public node_interfaces::LifecycleNodeInterface,
    */
   RCLCPP_LIFECYCLE_PUBLIC
   const State &
-  get_current_state();
+  get_current_state() const;
 
   /// Return a list with the available states.
   /**

rclcpp_lifecycle/src/lifecycle_node.cpp

@@ -503,7 +503,7 @@ LifecycleNode::register_on_error(
 }
 
 const State &
-LifecycleNode::get_current_state()
+LifecycleNode::get_current_state() const
 {
   return impl_->get_current_state();
 }

rclcpp_lifecycle/src/lifecycle_node_interface_impl.cpp

@@ -196,6 +196,8 @@ LifecycleNode::LifecycleNodeInterfaceImpl::init(bool enable_communication_interf
         nullptr);
     }
   }
+
+  current_state_ = State(state_machine_.current_state);
 }
 
 bool
@@ -341,9 +343,8 @@ LifecycleNode::LifecycleNodeInterfaceImpl::on_get_transition_graph(
 }
 
 const State &
-LifecycleNode::LifecycleNodeInterfaceImpl::get_current_state()
+LifecycleNode::LifecycleNodeInterfaceImpl::get_current_state() const
 {
-  current_state_ = State(state_machine_.current_state);
   return current_state_;
 }
 
@@ -410,6 +411,9 @@ LifecycleNode::LifecycleNodeInterfaceImpl::change_state(
     return RCL_RET_ERROR;
   }
 
+  // Update the internal current_state_
+  current_state_ = State(state_machine_.current_state);
+
   auto get_label_for_return_code =
     [](node_interfaces::LifecycleNodeInterface::CallbackReturn cb_return_code) -> const char *{
       auto cb_id = static_cast<uint8_t>(cb_return_code);
@@ -435,6 +439,9 @@ LifecycleNode::LifecycleNodeInterfaceImpl::change_state(
     return RCL_RET_ERROR;
   }
 
+  // Update the internal current_state_
+  current_state_ = State(state_machine_.current_state);
+
   // error handling ?!
   // TODO(karsten1987): iterate over possible ret value
   if (cb_return_code == node_interfaces::LifecycleNodeInterface::CallbackReturn::ERROR) {
@@ -451,6 +458,10 @@ LifecycleNode::LifecycleNodeInterfaceImpl::change_state(
       return RCL_RET_ERROR;
     }
   }
+
+  // Update the internal current_state_
+  current_state_ = State(state_machine_.current_state);
+
   // This true holds in both cases where the actual callback
   // was successful or not, since at this point we have a valid transistion
   // to either a new primary state or error state

rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp

@@ -65,7 +65,7 @@ class LifecycleNode::LifecycleNodeInterfaceImpl final
     std::function<node_interfaces::LifecycleNodeInterface::CallbackReturn(const State &)> & cb);
 
   const State &
-  get_current_state();
+  get_current_state() const;
 
   std::vector<State>
   get_available_states() const;