fixed address range parsing

Author: irockel

tda/src/main/java/de/grimmfrost/tda/parser/SunJDKParser.java

@@ -1046,15 +1046,13 @@ public String[] getThreadTokens(String name) {
                     tokens[4] = nidToken;
                 }
 
-                if (strippedToken.indexOf('[') > 0) {
+                if (strippedToken.lastIndexOf('[') > strippedToken.indexOf("nid=")) {
                     if (strippedToken.indexOf("lwp_id=") > 0) {
-                        tokens[5] = strippedToken.substring(strippedToken.indexOf(" ", strippedToken.indexOf("lwp_id=")) + 1, strippedToken.indexOf('[',
-                                strippedToken.indexOf("lwp_id=")) - 1);
+                        tokens[5] = strippedToken.substring(strippedToken.indexOf(" ", strippedToken.indexOf("lwp_id=")) + 1, strippedToken.lastIndexOf('[') - 1);
                     } else {
-                        tokens[5] = strippedToken.substring(strippedToken.indexOf(" ", strippedToken.indexOf("nid=")) + 1, strippedToken.indexOf('[',
-                                strippedToken.indexOf("nid=")) - 1);
+                        tokens[5] = strippedToken.substring(strippedToken.indexOf(" ", strippedToken.indexOf("nid=")) + 1, strippedToken.lastIndexOf('[') - 1);
                     }
-                    tokens[6] = strippedToken.substring(strippedToken.indexOf('['));
+                    tokens[6] = strippedToken.substring(strippedToken.lastIndexOf('['));
                 } else {
                     tokens[5] = strippedToken.substring(strippedToken.indexOf(" ", strippedToken.indexOf("nid=")) + 1);
                 }

tda/src/main/resources/de/grimmfrost/tda/doc/README

@@ -6,6 +6,9 @@ TDA - Thread Dump Analyzer -- Version 2.7
 Note: This is the 2.7 release of the software, for an usage overview see Help/Overview.
 
 Changes from 2.6 are:
+* Introduced logging for easier debugging in MCP mode, added red dot in UI mode if error
+  occurred with tooltip to check logfile.
+* Fixed address range parsing in thread titles for newer JVMs.
 * Fixed missing protocolVersion in MCP, which broke the Cursor Integration.
 * Experimental support for JSON based jmap thread dumps.
 * Support for SMR parsing in thread dumps (Java 11+)

tda/src/test/java/de/grimmfrost/tda/parser/SunJDKParserTest.java

@@ -503,4 +503,23 @@ public void testLongRunningDetectionWithVariableFields() throws IOException {
             }
         }
     }
+    @Test
+    public void testGetThreadTokensWithThreadTypeNumber() {
+        Map<String, Map<String, String>> threadStore = new HashMap<>();
+        SunJDKParser parser = new SunJDKParser(new BufferedReader(new StringReader("")), threadStore, 0, false, 0, new DateMatcher());
+
+        // Line from carrier_stuck.log
+        String line = "\"ForkJoinPool-1-worker-1\" #11 daemon [11] prio=5 os_prio=0 cpu=5678.90ms elapsed=58230.14s tid=0x00007f8b2c158000 nid=0x1ac7 runnable  [0x00007f8b234f5000]";
+
+        String[] tokens = parser.getThreadTokens(line);
+
+        // tokens: 0: name, 1: type, 2: prio, 3: tid, 4: nid, 5: state, 6: address
+        assertEquals("ForkJoinPool-1-worker-1", tokens[0], "Thread Name");
+        assertEquals("Daemon", tokens[1], "Thread Type");
+        assertEquals("5", tokens[2], "Priority");
+        assertEquals(String.valueOf(Long.parseLong("00007f8b2c158000", 16)), tokens[3], "TID");
+        assertEquals(String.valueOf(Long.parseLong("1ac7", 16)), tokens[4], "NID");
+        assertEquals("runnable", tokens[5].trim(), "State");
+        assertEquals("[0x00007f8b234f5000]", tokens[6], "Address Range");
+    }
 }