fixed icon in macos binary

Author: irockel

.github/workflows/release.yml

@@ -25,7 +25,7 @@ jobs:
 
       - name: Build macOS Binary
         run: |
-          mvn clean package -DskipTests -pl tda,tda-macos-binary -am
+          mvn clean package -Prelease -DskipTests -pl tda,tda-macos-binary -am
 
       - name: Upload macOS Binary to Release
         uses: softprops/action-gh-release@v2
@@ -54,7 +54,7 @@ jobs:
           cache: 'maven'
 
       - name: Build with Maven
-        run: mvn clean package -DskipTests -pl !tda-macos-binary
+        run: mvn clean package -DskipTests
 
       - name: Create Release
         id: create_release

README.md

@@ -175,6 +175,12 @@ This will build all components:
 *   The standalone TDA JAR (in `tda/target/tda-x.x.jar`).
 *   The VisualVM plugins as NBM files (in the `target/` directory of each `visualvm-*` module).
 
+To build the macOS DMG package, use the `release` profile (requires macOS and JDK 17+):
+
+```bash
+mvn clean package -Prelease
+```
+
 The resulting standalone JAR will also be located in the `tda/target/` directory.
 
 ---

pom.xml

@@ -15,9 +15,17 @@
         <module>visualvm-lib-component</module>
         <module>visualvm-logfile-component</module>
         <module>visualvm-module</module>
-        <module>tda-macos-binary</module>
     </modules>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <modules>
+                <module>tda-macos-binary</module>
+            </modules>
+        </profile>
+    </profiles>
+
     <repositories>
         <repository>
             <id>netbeans</id>

tda-macos-binary/pom.xml

@@ -74,7 +74,7 @@
                             </javaOptions>
                             <macPackageIdentifier>de.grimmfrost.tda</macPackageIdentifier>
                             <macPackageName>TDA</macPackageName>
-                            <icon>src/main/resources/TDA.png</icon>
+                            <icon>src/main/resources/TDA.icns</icon>
                         </configuration>
                     </execution>
                 </executions>