cleanup, notes in readme

Author: irockel

tda/src/main/java/de/grimmfrost/tda/parser/AbstractDumpParser.java

@@ -34,7 +34,7 @@
 import javax.swing.tree.TreePath;
 
 /**
- * abstract dump parser class, contains all generic dump parser
+ * Abstract dump parser class, contains all generic dump parser
  * stuff, which doesn't have any jdk specific parsing code.
  * 
  * All Dump Parser should extend from this class as it already provides

tda/src/main/java/de/grimmfrost/tda/parser/BeaJDKParser.java

@@ -41,9 +41,9 @@ public interface DumpParser {
 
     public void close() throws IOException;
 
-    public void findLongRunningThreads(DefaultMutableTreeNode root, Map dumpStore, TreePath[] paths, int minOccurence, String regex);
+    public void findLongRunningThreads(DefaultMutableTreeNode root, Map<String, Map<String, String>> dumpStore, TreePath[] paths, int minOccurrence, String regex);
 
-    public void mergeDumps(DefaultMutableTreeNode root, Map dumpStore, TreePath[] dumps, int minOccurence, String regex);
+    public void mergeDumps(DefaultMutableTreeNode root, Map<String, Map<String, String>> dumpStore, TreePath[] dumps, int minOccurrence, String regex);
 
     public boolean isFoundClassHistograms();
 

tda/src/main/java/de/grimmfrost/tda/parser/DumpParser.java

@@ -11,6 +11,7 @@
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStream;
+import java.util.Arrays;
 import java.util.Map;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -27,9 +28,9 @@ public class JCmdJSONParser extends AbstractDumpParser {
     private boolean hasMore = true;
     private int counter = 1;
 
-    private Map threadStore;
+    private Map<String, Map<String, String>> threadStore;
 
-    public JCmdJSONParser(BufferedReader bis, Map threadStore, int lineCounter, DateMatcher dm) {
+    public JCmdJSONParser(BufferedReader bis, Map<String, Map<String, String>> threadStore, int lineCounter, DateMatcher dm) {
         super(bis, dm);
         this.threadStore = threadStore;
     }
@@ -113,8 +114,8 @@ protected String[] getThreadTokens(String title) {
         String[] tokens = new String[7];
         // Minimal implementation for now, matching SunJDKParser's structure if possible
         // tokens: 0: name, 1: type, 2: prio, 3: tid, 4: nid, 5: state, 6: address
-        
-        for (int i = 0; i < tokens.length; i++) tokens[i] = "";
+
+        Arrays.fill(tokens, "");
 
         if (title.startsWith("\"")) {
             int endQuote = title.indexOf("\"", 1);

tda/src/main/java/de/grimmfrost/tda/parser/JCmdJSONParser.java

@@ -32,7 +32,7 @@ public class WrappedSunJDKParser extends SunJDKParser {
    * Creates a new instance of WrappedSunJDKParser: A SunJDKParser reading a log
    * file created by the Tanuki Service Wrapper.
    */
-  public WrappedSunJDKParser(BufferedReader bis, Map threadStore, int lineCounter,
+  public WrappedSunJDKParser(BufferedReader bis, Map<String, Map<String, String>> threadStore, int lineCounter,
                              boolean withCurrentTimeStamp, int startCounter, DateMatcher dm) {
     super(bis, threadStore, lineCounter, withCurrentTimeStamp, startCounter, dm);
   }
@@ -46,7 +46,7 @@ public WrappedSunJDKParser(BufferedReader bis, Map threadStore, int lineCounter,
    */
   public static boolean checkForSupportedThreadDump(String logLine) {
     return logLine.startsWith("INFO   | jvm ")
-           && logLine.trim().indexOf(" | Full thread dump") >= 0;
+           && logLine.trim().contains(" | Full thread dump");
   }
 
   protected String getNextLine() throws IOException {

tda/src/main/java/de/grimmfrost/tda/parser/WrappedSunJDKParser.java

@@ -6,10 +6,9 @@ TDA - Thread Dump Analyzer -- Version 2.7
 Note: This is the 2.7 release of the software, for an usage overview see Help/Overview.
 
 Changes from 2.6 are:
+Features:
 * Introduced logging for easier debugging in MCP mode, added red dot in UI mode if error
   occurred with tooltip to check logfile.
-* Fixed address range parsing in thread titles for newer JVMs.
-* Fixed missing protocolVersion in MCP, which broke the Cursor Integration.
 * Experimental support for JSON based jmap thread dumps.
 * Support for SMR parsing in thread dumps (Java 11+)
 * Detect stuck Carrier Threads used by Virtual Threads in Java 21+ thread dumps.
@@ -19,6 +18,9 @@ Changes from 2.6 are:
 * Reworked the thread dump summary to provide information in a more compact way.
 * MacOS Binary is now provided.
 * Use flatplaf for a modern look and feel.
+Bugfixes:
+* Fixed address range parsing in thread titles for newer JVMs.
+* Fixed missing protocolVersion in MCP, which broke the Cursor Integration.
 
 Changes from 2.5 are:
 * TDA now is compiled with JDK 11, it requires Java 11 or higher to run, but still