[#215] Ignore build warnings in Boost include

And re-enable build warnings in the build script for the builder Dockerfile.

Author: alanking

.github/workflows/build-and-test-s3-api-ubuntu.yml

@@ -80,7 +80,6 @@ jobs:
               mkdir build
               cd build
               cmake \
-                -DIRODS_BUILD_WITH_WERROR=NO \
                 -DCMAKE_C_COMPILER_LAUNCHER=ccache \
                 -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
                 -GNinja \

build_packages.sh

@@ -4,6 +4,6 @@ set -x
 
 mkdir -p /_build_s3_api
 cd /_build_s3_api
-cmake -DIRODS_BUILD_WITH_WERROR=NO -GNinja /s3_api_source
+cmake -GNinja /s3_api_source
 ninja package
 cp ./*.deb /packages_output

core/include/irods/private/s3_api/authentication.hpp

@@ -1,7 +1,11 @@
 #ifndef IRODS_S3_API_AUTHENTICATION_HPP
 #define IRODS_S3_API_AUTHENTICATION_HPP
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
 #include <boost/beast.hpp>
+#pragma GCC diagnostic pop
+
 #include <boost/url.hpp>
 
 #include <optional>

core/include/irods/private/s3_api/common.hpp

@@ -9,7 +9,11 @@
 #include <irods/rodsErrorTable.h>
 
 #include <boost/beast/http/status.hpp>
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
 #include <boost/beast/http/string_body.hpp>
+#pragma GCC diagnostic pop
 
 #include <fmt/format.h>
 

core/include/irods/private/s3_api/common_routines.hpp

@@ -4,10 +4,10 @@
 #include <string>
 
 #include <fmt/format.h>
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #include <fmt/chrono.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
 
 #include <boost/uuid/uuid.hpp>
 #include <boost/uuid/uuid_generators.hpp>

core/include/irods/private/s3_api/transport.hpp

@@ -5,12 +5,16 @@
 #include <boost/asio/ip/tcp.hpp>
 #include <boost/asio/ssl.hpp>
 #include <boost/beast/core/tcp_stream.hpp>
-#include <boost/beast/http/string_body.hpp>
-#include <boost/beast/http/read.hpp>
-#include <boost/beast/http/write.hpp>
 #include <boost/beast/ssl.hpp>
 #include <boost/url/parse.hpp>
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
+#include <boost/beast/http/read.hpp>
+#include <boost/beast/http/string_body.hpp>
+#include <boost/beast/http/write.hpp>
+#pragma GCC diagnostic pop
+
 #include <string_view>
 #include <memory>
 

core/src/main.cpp

@@ -31,10 +31,10 @@
 #include <boost/program_options.hpp>
 #include <boost/url/parse.hpp>
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
 #include <boost/process.hpp>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
 
 #include <fmt/format.h>
 #include <nlohmann/json.hpp>