Skip to content

loads of SyntaxWarnings from irods_config.py #246

@SwooshyCueb

Description

@SwooshyCueb

Look like we're using is not in a lot of places where we should be using !=, as when I run the testing environment, I get loads of SyntaxWarnings from irods_config.py:

/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:132: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, create_user) is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:140: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, set_password) is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:170: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ec is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:181: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if rc is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:239: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, update_host_resolution_config ) is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:263: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ec is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:277: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if rc is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:295: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(on_container, chown_msiexec) is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:299: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(on_container,
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:306: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(on_container,
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:313: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(on_container,
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:345: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ec is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:357: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if rc is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:399: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, mkuser, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:407: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, mkuser, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:414: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, moduser, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:424: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, make_pt, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:434: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, make_ufs, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:441: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, make_hier, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:449: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, asq, user='irods') is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:457: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, reload_config, user='irods', workdir=context.irods_home()) is not 0:
/home/kitsinger/devstuff/renci/irods_testing_environment/irods_testing_environment/irods_config.py:469: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if execute.execute_command(container, reload_config, user='irods', workdir=context.irods_home()) is not 0:

Not a blocker for anything at the moment, just a nuisance.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions