Mark ServerBootConfig as Error when image retrieval fails (#142)

hardikdr · web-flow · commit 5cfb1cd2b883 · 2025-02-25T16:27:55.000+01:00
diff --git a/internal/controller/serverbootconfiguration_pxe_controller.go b/internal/controller/serverbootconfiguration_pxe_controller.go
@@ -102,6 +102,9 @@ func (r *ServerBootConfigurationPXEReconciler) reconcile(ctx context.Context, lo
 
 	kernelURL, initrdURL, squashFSURL, err := r.getImageDetailsFromConfig(ctx, config)
 	if err != nil {
+		if err := r.patchState(ctx, config, metalv1alpha1.ServerBootConfigurationStateError); err != nil {
+			return ctrl.Result{}, fmt.Errorf("failed to patch server boot config state to %s: %w", metalv1alpha1.ServerBootConfigurationStateError, err)
+		}
 		return ctrl.Result{}, fmt.Errorf("failed to get image details from BootConfig: %w", err)
 	}
 	log.V(1).Info("Extracted OS image layer details")

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,9 @@ func (r *ServerBootConfigurationPXEReconciler) reconcile(ctx context.Context, lo`
`102`	`102`
`103`	`103`	`kernelURL, initrdURL, squashFSURL, err := r.getImageDetailsFromConfig(ctx, config)`
`104`	`104`	`if err != nil {`
	`105`	`+ if err := r.patchState(ctx, config, metalv1alpha1.ServerBootConfigurationStateError); err != nil {`
	`106`	`+ return ctrl.Result{}, fmt.Errorf("failed to patch server boot config state to %s: %w", metalv1alpha1.ServerBootConfigurationStateError, err)`
	`107`	`+ }`
`105`	`108`	`return ctrl.Result{}, fmt.Errorf("failed to get image details from BootConfig: %w", err)`
`106`	`109`	`}`
`107`	`110`	`log.V(1).Info("Extracted OS image layer details")`