Calculate nat packet checksum manually for TAP devices

Python Checksum checks seem to fail. Will ignore for the
time-being.

Signed-off-by: Guvenc Gulce <[email protected]>

Author: guvenc

src/dp_nat.c

@@ -268,10 +268,10 @@ void dp_nat_chg_ip(struct dp_flow *df, struct rte_ipv4_hdr *ipv4_hdr,
 {
 	struct rte_udp_hdr *udp_hdr;
 	struct rte_tcp_hdr *tcp_hdr;
+	bool calc_cksum = dp_conf_get_nic_type() == DP_CONF_NIC_TYPE_TAP;
 
 	ipv4_hdr->hdr_checksum = 0;
 	m->ol_flags |= RTE_MBUF_F_TX_IPV4;
-	m->ol_flags |= RTE_MBUF_F_TX_IP_CKSUM;
 	m->tx_offload = 0;
 	m->l2_len = sizeof(struct rte_ether_hdr);
 	m->l3_len = rte_ipv4_hdr_len(ipv4_hdr);
@@ -280,22 +280,34 @@ void dp_nat_chg_ip(struct dp_flow *df, struct rte_ipv4_hdr *ipv4_hdr,
 	switch (df->l4_type) {
 		case IPPROTO_TCP:
 			tcp_hdr =  (struct rte_tcp_hdr *)(ipv4_hdr + 1);
-			tcp_hdr->cksum = 0;
-			m->ol_flags |= RTE_MBUF_F_TX_TCP_CKSUM;
 			m->l4_len = DP_TCP_HDR_LEN(tcp_hdr);
+			tcp_hdr->cksum = 0;
+			if (unlikely(calc_cksum)) {
+				tcp_hdr->cksum = rte_ipv4_udptcp_cksum(ipv4_hdr, tcp_hdr);
+			} else {
+				m->ol_flags |= RTE_MBUF_F_TX_TCP_CKSUM;
+			}
 		break;
 		case IPPROTO_UDP:
 			udp_hdr =  (struct rte_udp_hdr *)(ipv4_hdr + 1);
-			udp_hdr->dgram_cksum = 0;
-			m->ol_flags |= RTE_MBUF_F_TX_UDP_CKSUM;
 			m->l4_len = sizeof(struct rte_udp_hdr);
+			udp_hdr->dgram_cksum = 0;
+			if (unlikely(calc_cksum)) {
+				udp_hdr->dgram_cksum = rte_ipv4_udptcp_cksum(ipv4_hdr, udp_hdr);
+			} else {
+				m->ol_flags |= RTE_MBUF_F_TX_UDP_CKSUM;
+			}
 		break;
 		case IPPROTO_ICMP:
 			m->l4_len = sizeof(struct rte_icmp_hdr);
 		break;
 		default:
 		break;
 	}
+	if (unlikely(calc_cksum))
+		ipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr);
+	else
+		m->ol_flags |= RTE_MBUF_F_TX_IP_CKSUM;
 }
 
 static void dp_calculate_icmp_checksum(struct rte_icmp_hdr *icmp_hdr, size_t icmp_len)