Better logging for snat portoverload deletion error

PlagueCZ · PlagueCZ · commit c52b30679944 · 2025-07-22T15:42:51.000+02:00
diff --git a/src/dp_nat.c b/src/dp_nat.c
@@ -774,11 +774,12 @@ int dp_remove_network_snat_port(const struct flow_value *cntrack)
 			}
 			rte_free(portmap_data);
 		}
-	} else if (ret != -ENOENT) {
-		DPS_LOG_ERR("Cannot lookup portoverload key", DP_LOG_RET(ret));
-		return ret;
+	} else {
+		DPS_LOG_ERR("Cannot lookup portmap key", DP_LOG_RET(ret));
+		if (ret != -ENOENT)
+			return ret;
+		// otherwise already deleted, finish
 	}
-	// otherwise already deleted, finish
 
 	created_port = dp_get_port_by_id(cntrack->created_port_id);
 	if (!created_port)

Original file line number	Diff line number	Diff line change
`@@ -774,11 +774,12 @@ int dp_remove_network_snat_port(const struct flow_value *cntrack)`
`774`	`774`	`}`
`775`	`775`	`rte_free(portmap_data);`
`776`	`776`	`}`
`777`		`- } else if (ret != -ENOENT) {`
`778`		`- DPS_LOG_ERR("Cannot lookup portoverload key", DP_LOG_RET(ret));`
`779`		`- return ret;`
	`777`	`+ } else {`
	`778`	`+ DPS_LOG_ERR("Cannot lookup portmap key", DP_LOG_RET(ret));`
	`779`	`+ if (ret != -ENOENT)`
	`780`	`+ return ret;`
	`781`	`+ // otherwise already deleted, finish`
`780`	`782`	`}`
`781`		`- // otherwise already deleted, finish`
`782`	`783`
`783`	`784`	`created_port = dp_get_port_by_id(cntrack->created_port_id);`
`784`	`785`	`if (!created_port)`