Skip to content

Commit 5ff91a3

Browse files
committed
incorporating review comments
1 parent 5ae06fc commit 5ff91a3

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

docs/usage/networking/loadbalancer.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ spec:
2020
app: web
2121
ports:
2222
- port: 80
23-
#status:
24-
# ips:
25-
# - 10.0.0.1 # The publicly available IP of the load balancer
2623
2724
```
2825
(`Note`: Refer to <a href="https://github.com/ironcore-dev/ironcore/tree/main/config/samples/e2e/loadbalancer-public">E2E Examples</a> for more detailed examples.)
@@ -64,3 +61,4 @@ destinations:
6461
- name: my-machine-interface-2
6562
uid: 2020dcf9-e030-427e-b0fc-4fec2016e73d
6663
```
64+
**LoadBalancer status update**: The `LoadBalancerController` in ironcore-net takes care of allocating IPs for defined `ipFamilies` in the spec and updates them in its `status.ips`.

docs/usage/networking/network.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ spec:
2626

2727
# Reconciliation Process:
2828

29-
- **Network creation**: `ironcore-net` which is the network provider for Ironcore realizes the `Network` resource and updates
30-
providerID in the spec. Once resource is in available state status is marked to `Available`.
29+
- **Network creation**: `ironcore-net` which is the network provider for Ironcore realizes the `Network` resource via `apinetlet` controllers. When an Ironcore `Network` is created, a corresponding `core.apinet.ironcore.dev/Network` is created in the apinet cluster. The name of the Network in the apinet cluster is the uid of the Network in the Ironcore cluster.
30+
31+
Once created and with an allocated ID, the Ironcore Network will be patched with the corresponding provider ID of the apinet Network and set to state: Available. The provider ID format & parsing can be found in provider.go.
32+
Once resource is in available state status is marked to `Available`. The format of a network provider ID is as follows:
33+
`ironcore-net://<namespace>/<name>/<id>/<uid>`
3134

3235
- **Network peering process**: Network peering is a technique used to interleave two isolated networks, allowing members of both networks to communicate with each
3336
other as if they were in the same networking domain, `NetworkPeeringController` facilitates this process.

0 commit comments

Comments
 (0)