Switch NameIsDNS validation to NameIsSubdomain validation (#1400)

afritzler · web-flow · commit eaa9aba60cb8 · 2025-10-22T13:34:12.000+02:00
Switch `NameIsDNS` validation to `NameIsSubdomain` validation for
`compute`, `storage` and `networking` resources.
diff --git a/internal/apis/compute/validation/machine.go b/internal/apis/compute/validation/machine.go
@@ -74,7 +74,7 @@ func validateMachineSpec(machineSpec *compute.MachineSpec, fldPath *field.Path)
 		allErrs = append(allErrs, field.Required(fldPath.Child("machineClassRef"), "must specify a machine class ref"))
 	}
 
-	for _, msg := range apivalidation.NameIsDNSLabel(machineSpec.MachineClassRef.Name, false) {
+	for _, msg := range apivalidation.NameIsDNSSubdomain(machineSpec.MachineClassRef.Name, false) {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("machineClassRef").Child("name"), machineSpec.MachineClassRef.Name, msg))
 	}
 
@@ -87,13 +87,13 @@ func validateMachineSpec(machineSpec *compute.MachineSpec, fldPath *field.Path)
 	allErrs = append(allErrs, validateMachinePower(machineSpec.Power, fldPath.Child("power"))...)
 
 	if machineSpec.IgnitionRef != nil && machineSpec.IgnitionRef.Name != "" {
-		for _, msg := range apivalidation.NameIsDNSLabel(machineSpec.IgnitionRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(machineSpec.IgnitionRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("ignitionRef").Child("name"), machineSpec.IgnitionRef.Name, msg))
 		}
 	}
 
 	if machineSpec.ImagePullSecretRef != nil {
-		for _, msg := range apivalidation.NameIsDNSLabel(machineSpec.ImagePullSecretRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(machineSpec.ImagePullSecretRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("imagePullSecretRef").Child("name"), machineSpec.ImagePullSecretRef.Name, msg))
 		}
 	}
diff --git a/internal/apis/compute/validation/machineclass.go b/internal/apis/compute/validation/machineclass.go
@@ -15,7 +15,7 @@ import (
 func ValidateMachineClass(machineClass *compute.MachineClass) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(machineClass, false, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(machineClass, false, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 
 	allErrs = append(allErrs, validateMachineClassCapabilities(machineClass.Capabilities, field.NewPath("capabilities"))...)
 
diff --git a/internal/apis/core/validation/resourcequota.go b/internal/apis/core/validation/resourcequota.go
@@ -14,7 +14,7 @@ import (
 func ValidateResourceQuota(resourceQuota *core.ResourceQuota) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(resourceQuota, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(resourceQuota, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 	allErrs = append(allErrs, validateResourceQuotaSpec(&resourceQuota.Spec, field.NewPath("spec"))...)
 
 	return allErrs
diff --git a/internal/apis/ipam/validation/prefix.go b/internal/apis/ipam/validation/prefix.go
@@ -21,7 +21,7 @@ import (
 func ValidatePrefix(prefix *ipam.Prefix) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(prefix, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(prefix, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 	allErrs = append(allErrs, ValidatePrefixSpec(&prefix.Spec, field.NewPath("spec"))...)
 
 	return allErrs
diff --git a/internal/apis/networking/validation/common.go b/internal/apis/networking/validation/common.go
@@ -62,7 +62,7 @@ func validatePrefixSource(src networking.PrefixSource, idx int, objectMeta *meta
 			allErrs = append(allErrs, ValidatePrefixPrefixTemplate(ephemeral.PrefixTemplate, fldPath.Child("ephemeral"))...)
 			if objectMeta != nil && objectMeta.Name != "" {
 				prefixName := networking.NetworkInterfacePrefixIPAMPrefixName(objectMeta.Name, idx)
-				for _, msg := range apivalidation.NameIsDNSLabel(prefixName, false) {
+				for _, msg := range apivalidation.NameIsDNSSubdomain(prefixName, false) {
 					allErrs = append(allErrs, field.Invalid(fldPath, prefixName, fmt.Sprintf("resulting prefix name %q is invalid: %s", prefixName, msg)))
 				}
 			}
diff --git a/internal/apis/networking/validation/loadbalancer.go b/internal/apis/networking/validation/loadbalancer.go
@@ -36,7 +36,7 @@ func validateLoadBalancerSpec(spec *networking.LoadBalancerSpec, lbMeta *metav1.
 
 	allErrs = append(allErrs, validateNetworkInterfaceIPSources(spec.IPs, spec.IPFamilies, lbMeta, fldPath.Child("ips"))...)
 
-	for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {
+	for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))
 	}
 
diff --git a/internal/apis/networking/validation/loadbalancerrouting.go b/internal/apis/networking/validation/loadbalancerrouting.go
@@ -14,7 +14,7 @@ import (
 func ValidateLoadBalancerRouting(loadBalancerRouting *networking.LoadBalancerRouting) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(loadBalancerRouting, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(loadBalancerRouting, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 	allErrs = append(allErrs, validateLoadBalancerRouting(loadBalancerRouting)...)
 
 	return allErrs
@@ -31,7 +31,7 @@ func validateLoadBalancerRouting(loadBalancerRouting *networking.LoadBalancerRou
 		allErrs = append(allErrs, commonvalidation.ValidateIP(destination.IP.Family(), destination.IP, fldPath.Child("ip"))...)
 
 		if targetRef := destination.TargetRef; targetRef != nil {
-			for _, msg := range apivalidation.NameIsDNSLabel(targetRef.Name, false) {
+			for _, msg := range apivalidation.NameIsDNSSubdomain(targetRef.Name, false) {
 				allErrs = append(allErrs, field.Invalid(fldPath.Child("targetRef", "name"), targetRef.Name, msg))
 			}
 		}
diff --git a/internal/apis/networking/validation/natgateway.go b/internal/apis/networking/validation/natgateway.go
@@ -28,7 +28,7 @@ func validateNATGatewaySpec(spec *networking.NATGatewaySpec, fldPath *field.Path
 
 	allErrs = append(allErrs, ironcorevalidation.ValidateIPFamily(spec.IPFamily, fldPath.Child("ipFamily"))...)
 
-	for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {
+	for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))
 	}
 
diff --git a/internal/apis/networking/validation/network.go b/internal/apis/networking/validation/network.go
@@ -17,7 +17,7 @@ import (
 func ValidateNetwork(network *networking.Network) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(network, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(network, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 	allErrs = append(allErrs, validateNetworkSpec(network.Namespace, network.Name, &network.Spec, field.NewPath("spec"))...)
 
 	return allErrs
@@ -113,7 +113,7 @@ func validateNetworkSpec(namespace, name string, spec *networking.NetworkSpec, f
 func validateNetworkPeering(peering networking.NetworkPeering, fldPath *field.Path) field.ErrorList {
 	var allErrs field.ErrorList
 
-	for _, msg := range apivalidation.NameIsDNSLabel(peering.Name, false) {
+	for _, msg := range apivalidation.NameIsDNSSubdomain(peering.Name, false) {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("name"), peering.Name, msg))
 	}
 
@@ -123,7 +123,7 @@ func validateNetworkPeering(peering networking.NetworkPeering, fldPath *field.Pa
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef", "namespace"), networkRef.Namespace, msg))
 		}
 	}
-	for _, msg := range apivalidation.NameIsDNSLabel(networkRef.Name, false) {
+	for _, msg := range apivalidation.NameIsDNSSubdomain(networkRef.Name, false) {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef", "name"), networkRef.Name, msg))
 	}
 
@@ -136,13 +136,13 @@ func validatePeeringClaimRef(peeringClaimRef networking.NetworkPeeringClaimRef,
 	if len(peeringClaimRef.Name) == 0 {
 		allErrs = append(allErrs, field.Required(fldPath.Child("name"), "name is required"))
 	} else {
-		for _, msg := range apivalidation.NameIsDNSLabel(peeringClaimRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(peeringClaimRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("name"), peeringClaimRef.Name, msg))
 		}
 	}
 
 	if peeringClaimRef.Namespace != "" {
-		for _, msg := range apivalidation.NameIsDNSLabel(peeringClaimRef.Namespace, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(peeringClaimRef.Namespace, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("namespace"), peeringClaimRef.Namespace, msg))
 		}
 	}
diff --git a/internal/apis/networking/validation/networkinterface.go b/internal/apis/networking/validation/networkinterface.go
@@ -44,7 +44,7 @@ func ValidateNetworkInterfaceSpec(spec *networking.NetworkInterfaceSpec, nicMeta
 		allErrs = append(allErrs, field.Required(fldPath.Child("networkRef"), "must specify a network ref"))
 	}
 
-	for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {
+	for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {
 		allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))
 	}
 
diff --git a/internal/apis/networking/validation/networkpolicy.go b/internal/apis/networking/validation/networkpolicy.go
@@ -21,7 +21,7 @@ import (
 func ValidateNetworkPolicy(networkPolicy *networking.NetworkPolicy) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(networkPolicy, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(networkPolicy, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 	allErrs = append(allErrs, validateNetworkPolicySpec(&networkPolicy.Spec, field.NewPath("spec"))...)
 
 	return allErrs
@@ -33,7 +33,7 @@ func validateNetworkPolicySpec(spec *networking.NetworkPolicySpec, fldPath *fiel
 	if spec.NetworkRef == (corev1.LocalObjectReference{}) {
 		allErrs = append(allErrs, field.Required(fldPath.Child("networkRef"), "must specify a network ref"))
 	} else {
-		for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))
 		}
 	}
diff --git a/internal/apis/networking/validation/virtualip.go b/internal/apis/networking/validation/virtualip.go
@@ -47,7 +47,7 @@ func validateVirtualIPSpec(spec *networking.VirtualIPSpec, fldPath *field.Path)
 	allErrs = append(allErrs, ironcorevalidation.ValidateIPFamily(spec.IPFamily, fldPath.Child("ipFamily"))...)
 
 	if targetRef := spec.TargetRef; targetRef != nil {
-		for _, msg := range apivalidation.NameIsDNSLabel(targetRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(targetRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("targetRef", "name"), targetRef.Name, msg))
 		}
 	}
diff --git a/internal/apis/storage/validation/volume.go b/internal/apis/storage/validation/volume.go
@@ -29,7 +29,7 @@ func validateVolumeSpec(spec *storage.VolumeSpec, fldPath *field.Path) field.Err
 	var allErrs field.ErrorList
 
 	if volumeClassRef := spec.VolumeClassRef; volumeClassRef != nil {
-		for _, msg := range apivalidation.NameIsDNSLabel(spec.VolumeClassRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(spec.VolumeClassRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("volumeClassRef").Child("name"), spec.VolumeClassRef.Name, msg))
 		}
 
@@ -49,7 +49,7 @@ func validateVolumeSpec(spec *storage.VolumeSpec, fldPath *field.Path) field.Err
 		}
 
 		if spec.ImagePullSecretRef != nil {
-			for _, msg := range apivalidation.NameIsDNSLabel(spec.ImagePullSecretRef.Name, false) {
+			for _, msg := range apivalidation.NameIsDNSSubdomain(spec.ImagePullSecretRef.Name, false) {
 				allErrs = append(allErrs, field.Invalid(fldPath.Child("imagePullSecretRef").Child("name"), spec.ImagePullSecretRef.Name, msg))
 			}
 		}
@@ -89,14 +89,14 @@ func validateVolumeSpec(spec *storage.VolumeSpec, fldPath *field.Path) field.Err
 		}
 	} else {
 		if spec.ClaimRef != nil {
-			for _, msg := range apivalidation.NameIsDNSLabel(spec.ClaimRef.Name, false) {
+			for _, msg := range apivalidation.NameIsDNSSubdomain(spec.ClaimRef.Name, false) {
 				allErrs = append(allErrs, field.Invalid(fldPath.Child("claimRef").Child("name"), spec.ClaimRef.Name, msg))
 			}
 		}
 	}
 
 	if spec.Encryption != nil {
-		for _, msg := range apivalidation.NameIsDNSLabel(spec.Encryption.SecretRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(spec.Encryption.SecretRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("encryption").Child("secretRef").Child("name"), spec.Encryption.SecretRef.Name, msg))
 		}
 	}
diff --git a/internal/apis/storage/validation/volumeclass.go b/internal/apis/storage/validation/volumeclass.go
@@ -15,7 +15,7 @@ import (
 func ValidateVolumeClass(volumeClass *storage.VolumeClass) field.ErrorList {
 	var allErrs field.ErrorList
 
-	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(volumeClass, false, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)
+	allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(volumeClass, false, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)
 
 	allErrs = append(allErrs, validateVolumeClassCapabilities(volumeClass.Capabilities, field.NewPath("capabilities"))...)
 
diff --git a/internal/apis/storage/validation/volumesnapshot.go b/internal/apis/storage/validation/volumesnapshot.go
@@ -23,7 +23,7 @@ func validateVolumeSnapshotSpec(spec *storage.VolumeSnapshotSpec, fldPath *field
 	var allErrs field.ErrorList
 
 	if spec.VolumeRef != nil {
-		for _, msg := range apivalidation.NameIsDNSLabel(spec.VolumeRef.Name, false) {
+		for _, msg := range apivalidation.NameIsDNSSubdomain(spec.VolumeRef.Name, false) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("volumeRef").Child("name"), spec.VolumeRef.Name, msg))
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ func validateMachineSpec(machineSpec compute.MachineSpec, fldPath field.Path)`
`74`	`74`	`allErrs = append(allErrs, field.Required(fldPath.Child("machineClassRef"), "must specify a machine class ref"))`
`75`	`75`	`}`
`76`	`76`
`77`		`- for _, msg := range apivalidation.NameIsDNSLabel(machineSpec.MachineClassRef.Name, false) {`
	`77`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(machineSpec.MachineClassRef.Name, false) {`
`78`	`78`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("machineClassRef").Child("name"), machineSpec.MachineClassRef.Name, msg))`
`79`	`79`	`}`
`80`	`80`
`@@ -87,13 +87,13 @@ func validateMachineSpec(machineSpec compute.MachineSpec, fldPath field.Path)`
`87`	`87`	`allErrs = append(allErrs, validateMachinePower(machineSpec.Power, fldPath.Child("power"))...)`
`88`	`88`
`89`	`89`	`if machineSpec.IgnitionRef != nil && machineSpec.IgnitionRef.Name != "" {`
`90`		`- for _, msg := range apivalidation.NameIsDNSLabel(machineSpec.IgnitionRef.Name, false) {`
	`90`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(machineSpec.IgnitionRef.Name, false) {`
`91`	`91`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("ignitionRef").Child("name"), machineSpec.IgnitionRef.Name, msg))`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`if machineSpec.ImagePullSecretRef != nil {`
`96`		`- for _, msg := range apivalidation.NameIsDNSLabel(machineSpec.ImagePullSecretRef.Name, false) {`
	`96`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(machineSpec.ImagePullSecretRef.Name, false) {`
`97`	`97`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("imagePullSecretRef").Child("name"), machineSpec.ImagePullSecretRef.Name, msg))`
`98`	`98`	`}`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ func validatePrefixSource(src networking.PrefixSource, idx int, objectMeta *meta`
`62`	`62`	`allErrs = append(allErrs, ValidatePrefixPrefixTemplate(ephemeral.PrefixTemplate, fldPath.Child("ephemeral"))...)`
`63`	`63`	`if objectMeta != nil && objectMeta.Name != "" {`
`64`	`64`	`prefixName := networking.NetworkInterfacePrefixIPAMPrefixName(objectMeta.Name, idx)`
`65`		`- for _, msg := range apivalidation.NameIsDNSLabel(prefixName, false) {`
	`65`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(prefixName, false) {`
`66`	`66`	`allErrs = append(allErrs, field.Invalid(fldPath, prefixName, fmt.Sprintf("resulting prefix name %q is invalid: %s", prefixName, msg)))`
`67`	`67`	`}`
`68`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func validateLoadBalancerSpec(spec networking.LoadBalancerSpec, lbMeta metav1.`
`36`	`36`
`37`	`37`	`allErrs = append(allErrs, validateNetworkInterfaceIPSources(spec.IPs, spec.IPFamilies, lbMeta, fldPath.Child("ips"))...)`
`38`	`38`
`39`		`- for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {`
	`39`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {`
`40`	`40`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ import (`
`14`	`14`	`func ValidateLoadBalancerRouting(loadBalancerRouting *networking.LoadBalancerRouting) field.ErrorList {`
`15`	`15`	`var allErrs field.ErrorList`
`16`	`16`
`17`		`- allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(loadBalancerRouting, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)`
	`17`	`+ allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(loadBalancerRouting, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)`
`18`	`18`	`allErrs = append(allErrs, validateLoadBalancerRouting(loadBalancerRouting)...)`
`19`	`19`
`20`	`20`	`return allErrs`
`@@ -31,7 +31,7 @@ func validateLoadBalancerRouting(loadBalancerRouting *networking.LoadBalancerRou`
`31`	`31`	`allErrs = append(allErrs, commonvalidation.ValidateIP(destination.IP.Family(), destination.IP, fldPath.Child("ip"))...)`
`32`	`32`
`33`	`33`	`if targetRef := destination.TargetRef; targetRef != nil {`
`34`		`- for _, msg := range apivalidation.NameIsDNSLabel(targetRef.Name, false) {`
	`34`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(targetRef.Name, false) {`
`35`	`35`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("targetRef", "name"), targetRef.Name, msg))`
`36`	`36`	`}`
`37`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ func validateNATGatewaySpec(spec networking.NATGatewaySpec, fldPath field.Path`
`28`	`28`
`29`	`29`	`allErrs = append(allErrs, ironcorevalidation.ValidateIPFamily(spec.IPFamily, fldPath.Child("ipFamily"))...)`
`30`	`30`
`31`		`- for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {`
	`31`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {`
`32`	`32`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ import (`
`17`	`17`	`func ValidateNetwork(network *networking.Network) field.ErrorList {`
`18`	`18`	`var allErrs field.ErrorList`
`19`	`19`
`20`		`- allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(network, true, apivalidation.NameIsDNSLabel, field.NewPath("metadata"))...)`
	`20`	`+ allErrs = append(allErrs, apivalidation.ValidateObjectMetaAccessor(network, true, apivalidation.NameIsDNSSubdomain, field.NewPath("metadata"))...)`
`21`	`21`	`allErrs = append(allErrs, validateNetworkSpec(network.Namespace, network.Name, &network.Spec, field.NewPath("spec"))...)`
`22`	`22`
`23`	`23`	`return allErrs`
`@@ -113,7 +113,7 @@ func validateNetworkSpec(namespace, name string, spec *networking.NetworkSpec, f`
`113`	`113`	`func validateNetworkPeering(peering networking.NetworkPeering, fldPath *field.Path) field.ErrorList {`
`114`	`114`	`var allErrs field.ErrorList`
`115`	`115`
`116`		`- for _, msg := range apivalidation.NameIsDNSLabel(peering.Name, false) {`
	`116`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(peering.Name, false) {`
`117`	`117`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("name"), peering.Name, msg))`
`118`	`118`	`}`
`119`	`119`
`@@ -123,7 +123,7 @@ func validateNetworkPeering(peering networking.NetworkPeering, fldPath *field.Pa`
`123`	`123`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef", "namespace"), networkRef.Namespace, msg))`
`124`	`124`	`}`
`125`	`125`	`}`
`126`		`- for _, msg := range apivalidation.NameIsDNSLabel(networkRef.Name, false) {`
	`126`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(networkRef.Name, false) {`
`127`	`127`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef", "name"), networkRef.Name, msg))`
`128`	`128`	`}`
`129`	`129`
`@@ -136,13 +136,13 @@ func validatePeeringClaimRef(peeringClaimRef networking.NetworkPeeringClaimRef,`
`136`	`136`	`if len(peeringClaimRef.Name) == 0 {`
`137`	`137`	`allErrs = append(allErrs, field.Required(fldPath.Child("name"), "name is required"))`
`138`	`138`	`} else {`
`139`		`- for _, msg := range apivalidation.NameIsDNSLabel(peeringClaimRef.Name, false) {`
	`139`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(peeringClaimRef.Name, false) {`
`140`	`140`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("name"), peeringClaimRef.Name, msg))`
`141`	`141`	`}`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`if peeringClaimRef.Namespace != "" {`
`145`		`- for _, msg := range apivalidation.NameIsDNSLabel(peeringClaimRef.Namespace, false) {`
	`145`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(peeringClaimRef.Namespace, false) {`
`146`	`146`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("namespace"), peeringClaimRef.Namespace, msg))`
`147`	`147`	`}`
`148`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ func ValidateNetworkInterfaceSpec(spec *networking.NetworkInterfaceSpec, nicMeta`
`44`	`44`	`allErrs = append(allErrs, field.Required(fldPath.Child("networkRef"), "must specify a network ref"))`
`45`	`45`	`}`
`46`	`46`
`47`		`- for _, msg := range apivalidation.NameIsDNSLabel(spec.NetworkRef.Name, false) {`
	`47`	`+ for _, msg := range apivalidation.NameIsDNSSubdomain(spec.NetworkRef.Name, false) {`
`48`	`48`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("networkRef").Child("name"), spec.NetworkRef.Name, msg))`
`49`	`49`	`}`
`50`	`50`