removes unused ctx param in redfish funcs

Author: stefanhipfel

bmc/bmc.go

@@ -121,10 +121,10 @@ type BMC interface {
 	DeleteAccount(ctx context.Context, userName, id string) error
 
 	// GetAccounts retrieves all BMC user accounts.
-	GetAccounts(ctx context.Context) ([]*redfish.ManagerAccount, error)
+	GetAccounts() ([]*redfish.ManagerAccount, error)
 
 	// GetAccountService retrieves the account service.
-	GetAccountService(ctx context.Context) (*redfish.AccountService, error)
+	GetAccountService() (*redfish.AccountService, error)
 }
 
 type Entity struct {

bmc/redfish.go

@@ -805,26 +805,24 @@ func (r *RedfishBMC) DeleteAccount(ctx context.Context, userName, id string) err
 			if err != nil {
 				return err
 			}
-			defer func(Body io.ReadCloser) {
-				if err = Body.Close(); err != nil {
-					log.Error(err, "failed to close response body")
-				}
-			}(resp.Body)
+			if err = resp.Body.Close(); err != nil {
+				log.Error(err, "failed to close response body")
+			}
 			return nil
 		}
 	}
 	return fmt.Errorf("account %s not found", userName)
 }
 
-func (r *RedfishBMC) GetAccountService(ctx context.Context) (*redfish.AccountService, error) {
+func (r *RedfishBMC) GetAccountService() (*redfish.AccountService, error) {
 	service, err := r.client.GetService().AccountService()
 	if err != nil {
 		return nil, fmt.Errorf("failed to get account service: %w", err)
 	}
 	return service, nil
 }
 
-func (r *RedfishBMC) GetAccounts(ctx context.Context) ([]*redfish.ManagerAccount, error) {
+func (r *RedfishBMC) GetAccounts() ([]*redfish.ManagerAccount, error) {
 	service, err := r.client.GetService().AccountService()
 	if err != nil {
 		return nil, fmt.Errorf("failed to get account service: %w", err)

bmc/redfish_local.go

@@ -53,7 +53,7 @@ func NewRedfishLocalBMCClient(ctx context.Context, options Options) (BMC, error)
 }
 
 // GetAccounts retrieves all user accounts from the BMC.
-func (r *RedfishLocalBMC) GetAccounts(ctx context.Context) ([]*redfish.ManagerAccount, error) {
+func (r *RedfishLocalBMC) GetAccounts() ([]*redfish.ManagerAccount, error) {
 	accounts := make([]*redfish.ManagerAccount, 0, len(UnitTestMockUps.Accounts))
 	for _, a := range UnitTestMockUps.Accounts {
 		accounts = append(accounts, a)

internal/controller/bmcuser_controller.go

@@ -125,7 +125,7 @@ func (r *BMCUserReconciler) reconcile(ctx context.Context, log logr.Logger, user
 }
 
 func (r *BMCUserReconciler) patchUserStatus(ctx context.Context, log logr.Logger, user *metalv1alpha1.BMCUser, bmcClient bmc.BMC) error {
-	accounts, err := bmcClient.GetAccounts(ctx)
+	accounts, err := bmcClient.GetAccounts()
 	if err != nil {
 		return fmt.Errorf("failed to get BMC accounts: %w", err)
 	}
@@ -183,7 +183,7 @@ func (r *BMCUserReconciler) handleRotatingPassword(ctx context.Context, log logr
 		}, nil
 	}
 	log.Info("Rotating BMC user password", "User", user.Name)
-	accountService, err := bmcClient.GetAccountService(ctx)
+	accountService, err := bmcClient.GetAccountService()
 	if err != nil {
 		return ctrl.Result{}, fmt.Errorf("failed to get account service: %w", err)
 	}
@@ -213,7 +213,7 @@ func (r *BMCUserReconciler) handleRotatingPassword(ctx context.Context, log logr
 
 func (r *BMCUserReconciler) ensureBMCSecretForUser(ctx context.Context, log logr.Logger, bmcClient bmc.BMC, user *metalv1alpha1.BMCUser, bmcObj *metalv1alpha1.BMC) error {
 	log.Info("No BMCSecret reference set for User, creating a new one", "User", user.Name)
-	accountService, err := bmcClient.GetAccountService(ctx)
+	accountService, err := bmcClient.GetAccountService()
 	if err != nil {
 		return fmt.Errorf("failed to get account service: %w", err)
 	}

internal/webhook/v1alpha1/bmcsecret_webhook_test.go

@@ -22,7 +22,6 @@ var _ = Describe("BMCSecret Webhook", func() {
 		validator = BMCSecretCustomValidator{
 			Client: k8sClient,
 		}
-		Expect(validator).NotTo(BeNil(), "Expected validator to be initialized")
 		BMCSecret = &metalv1alpha1.BMCSecret{
 			ObjectMeta: metav1.ObjectMeta{
 				Namespace:    "test-namespace",