[NXOS] Add annotation to force members on interface aggregates

Adding the annotation
`nx.cisco.networking.metal.ironcore.dev/channel-group-force` to an
interface of type `Aggregate` on a Cisco NX device forces the addition
of member interfaces  to the port-channel. The value of the annotation
is ignored.

Author: nikatza

config/samples/cisco/nx/v1alpha1_vpcdomain.yaml

@@ -85,7 +85,7 @@ metadata:
     networking.metal.ironcore.dev/device-name: leaf1
   annotations:
     nx.cisco.networking.metal.ironcore.dev/spanning-tree-port-type: "network"
-    nx.cisco.networking.metal.ironcore.dev/spanning-tree-bridge-assurance: "enabled"
+    nx.cisco.networking.metal.ironcore.dev/channel-group-force: ""
   name: po1
 spec:
   deviceRef:

internal/provider/cisco/nxos/intf.go

@@ -130,9 +130,8 @@ func NewVrfMember(ifName, vrfName string) *VrfMember {
 
 // SpanningTree represents the spanning tree configuration for an interface.
 type SpanningTree struct {
-	Mode   SpanningTreeMode      `json:"mode"`
-	IfName string                `json:"-"`
-	Bridge Option[BridgeControl] `json:"bridge"`
+	Mode   SpanningTreeMode `json:"mode"`
+	IfName string           `json:"-"`
 }
 
 func (*SpanningTree) IsListItem() {}
@@ -145,22 +144,6 @@ func (s *SpanningTree) Default() {
 	s.Mode = SpanningTreeModeDefault
 }
 
-type BridgeControl string
-
-const (
-	BridgeControlEnabled  BridgeControl = "enabled"
-	BridgeControlDisabled BridgeControl = "disabled"
-)
-
-func (b BridgeControl) IsValid() bool {
-	switch b {
-	case BridgeControlEnabled, BridgeControlDisabled:
-		return true
-	default:
-		return false
-	}
-}
-
 // PortChannel represents a port-channel (LAG) interface on a NX-OS device.
 type PortChannel struct {
 	AccessVlan    string          `json:"accessVlan"`
@@ -184,11 +167,21 @@ type PortChannelMember struct {
 	Force bool   `json:"isMbrForce,omitempty"`
 }
 
-func NewPortChannelMember(name string) *PortChannelMember {
-	return &PortChannelMember{
+type PortChannelMemberOption func(*PortChannelMember)
+
+func WithForce(force bool) PortChannelMemberOption {
+	return func(m *PortChannelMember) { m.Force = force }
+}
+
+func NewPortChannelMember(name string, opts ...PortChannelMemberOption) *PortChannelMember {
+	m := &PortChannelMember{
 		TDn:   fmt.Sprintf("/System/intf-items/phys-items/PhysIf-list[id='%s']", name),
 		Force: false,
 	}
+	for _, o := range opts {
+		o(m)
+	}
+	return m
 }
 
 func (m *PortChannelMember) Key() string { return m.TDn }

internal/provider/cisco/nxos/provider.go

@@ -31,8 +31,7 @@ import (
 
 const (
 	SpanningTreePortTypeAnnotation = "nx.cisco.networking.metal.ironcore.dev/spanning-tree-port-type"
-	// TODO: add to device controller
-	SpanningTreeBridgeAssuranceAnnotation = "nx.cisco.networking.metal.ironcore.dev/spanning-tree-bridge-assurance"
+	ChannelGroupForceAnnotation    = "nx.cisco.networking.metal.ironcore.dev/channel-group-force"
 )
 
 var (
@@ -764,12 +763,13 @@ func (p *Provider) EnsureInterface(ctx context.Context, req *provider.EnsureInte
 			}
 		}
 
+		_, force := req.Interface.GetAnnotations()[ChannelGroupForceAnnotation]
 		for _, member := range req.Members {
 			n, err := ShortNamePhysicalInterface(member.Spec.Name)
 			if err != nil {
 				return err
 			}
-			pc.RsmbrIfsItems.RsMbrIfsList.Set(NewPortChannelMember(n))
+			pc.RsmbrIfsItems.RsMbrIfsList.Set(NewPortChannelMember(n, WithForce(force)))
 		}
 
 		v := new(VPCIfItems)