Skip to content

Commit 8ae35e2

Browse files
committed
address PR comments
1 parent 9bb743e commit 8ae35e2

File tree

8 files changed

+13
-192
lines changed

8 files changed

+13
-192
lines changed

api/v1alpha1/zz_generated.deepcopy.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/network.ironcore.dev_igps.yaml

Lines changed: 0 additions & 173 deletions
This file was deleted.

config/manager/kustomization.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,2 @@
11
resources:
22
- manager.yaml
3-
apiVersion: kustomize.config.k8s.io/v1beta1
4-
kind: Kustomization
5-
images:
6-
- name: controller
7-
newName: controller
8-
newTag: latest

config/rbac/igp_admin_role.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This rule is not used by the project network-operator itself.
22
# It is provided to allow the cluster admin to help manage permissions for users.
33
#
4-
# Grants full permissions ('*') over network.ironcore.dev.
4+
# Grants full permissions ('*') over networking.cloud.sap.
55
# This role is intended for users authorized to modify roles and bindings within the cluster,
66
# enabling them to delegate specific permissions to other users or groups as needed.
77

@@ -14,13 +14,13 @@ metadata:
1414
name: igp-admin-role
1515
rules:
1616
- apiGroups:
17-
- network.ironcore.dev
17+
- networking.cloud.sap
1818
resources:
1919
- igps
2020
verbs:
2121
- '*'
2222
- apiGroups:
23-
- network.ironcore.dev
23+
- networking.cloud.sap
2424
resources:
2525
- igps/status
2626
verbs:

config/rbac/igp_editor_role.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This rule is not used by the project network-operator itself.
22
# It is provided to allow the cluster admin to help manage permissions for users.
33
#
4-
# Grants permissions to create, update, and delete resources within the network.ironcore.dev.
4+
# Grants permissions to create, update, and delete resources within the networking.cloud.sap.
55
# This role is intended for users who need to manage these resources
66
# but should not control RBAC or manage permissions for others.
77

@@ -14,7 +14,7 @@ metadata:
1414
name: igp-editor-role
1515
rules:
1616
- apiGroups:
17-
- network.ironcore.dev
17+
- networking.cloud.sap
1818
resources:
1919
- igps
2020
verbs:
@@ -26,7 +26,7 @@ rules:
2626
- update
2727
- watch
2828
- apiGroups:
29-
- network.ironcore.dev
29+
- networking.cloud.sap
3030
resources:
3131
- igps/status
3232
verbs:

config/rbac/igp_viewer_role.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This rule is not used by the project network-operator itself.
22
# It is provided to allow the cluster admin to help manage permissions for users.
33
#
4-
# Grants read-only access to network.ironcore.dev resources.
4+
# Grants read-only access to networking.cloud.sap resources.
55
# This role is intended for users who need visibility into these resources
66
# without permissions to modify them. It is ideal for monitoring purposes and limited-access viewing.
77

@@ -14,15 +14,15 @@ metadata:
1414
name: igps-viewer-role
1515
rules:
1616
- apiGroups:
17-
- network.ironcore.dev
17+
- networking.cloud.sap
1818
resources:
1919
- igps
2020
verbs:
2121
- get
2222
- list
2323
- watch
2424
- apiGroups:
25-
- network.ironcore.dev
25+
- networking.cloud.sap
2626
resources:
2727
- igps/status
2828
verbs:

config/samples/v1alpha1_igp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ spec:
1414
overloadBit:
1515
onStartup: 600
1616
addressFamilies:
17-
- v4-unicast
17+
- v4-unicast

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,8 @@ golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLL
199199
golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
200200
golang.org/x/net v0.38.0 h1:vRMAPTMaeGqVhG5QyLJHqNDwecKTomGeqbnfZyKlBI8=
201201
golang.org/x/net v0.38.0/go.mod h1:ivrbrMbzFq5J41QOQh0siUuly180yBYtLp+CKbEaFx8=
202-
golang.org/x/oauth2 v0.28.0 h1:CrgCKl8PPAVtLnU3c+EDw6x11699EWlsDeWNWKdIOkc=
203-
golang.org/x/oauth2 v0.28.0/go.mod h1:onh5ek6nERTohokkhCD/y2cV4Do3fxFHFuAejCkRWT8=
202+
golang.org/x/oauth2 v0.27.0 h1:da9Vo7/tDv5RH/7nZDz1eMGS/q1Vv1N/7FCrBhI9I3M=
203+
golang.org/x/oauth2 v0.27.0/go.mod h1:onh5ek6nERTohokkhCD/y2cV4Do3fxFHFuAejCkRWT8=
204204
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
205205
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
206206
golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=

0 commit comments

Comments
 (0)