Skip to content

Run go-makefile-maker #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikatza merged 4 commits into from
Jan 7, 2026
Merged

Run go-makefile-maker #146

nikatza merged 4 commits into from
Jan 7, 2026

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Jan 6, 2026

No description provided.

@felix-kaestner felix-kaestner requested a review from a team as a code owner January 6, 2026 12:09
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2 91.05% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 12.59% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/acl_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/gnmiext/v2/list.go 100.00% (ø) 24 24 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/ospf.go 25.00% (ø) 16 4 12
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.09% (ø) 1161 1 1160
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/snmp.go 81.82% (ø) 11 9 2
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/user.go 40.00% (ø) 40 16 24

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/snmp_test.go

@nikatza nikatza merged commit 4c4a814 into main Jan 7, 2026
8 checks passed
@nikatza nikatza deleted the gomm branch January 7, 2026 10:22
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jan 13, 2026
@hardikdr hardikdr added this to Roadmap Jan 13, 2026
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikatza nikatza nikatza approved these changes

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felix-kaestner @nikatza @hardikdr