Skip to content

Commit dae8dec

Browse files
RiflussoisXander
andauthored
disabling MC-61489 by default (#468)
* disabling MC-61489 by default * add fix explanation for MC-61489 --------- Co-authored-by: Xander <[email protected]>
1 parent 90bb8c2 commit dae8dec

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

src/client/java/dev/isxander/debugify/client/mixins/basic/mc61489/BookEditScreenMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import org.spongepowered.asm.mixin.injection.ModifyArg;
1313

1414
// Compared to the original patch, we use / 3 here since it seems to line up better. Else, in a windowed screen the Done button appears at the very bottom / slightly off-screen.
15-
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, modConflicts = {"fixbookgui", "scribble"}, description = "Book GUI is not vertically centered")
15+
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, enabled = false, modConflicts = {"fixbookgui", "stendhal", "scribble"}, description = "Book GUI is not vertically centered")
1616
@Mixin(BookEditScreen.class)
1717
public class BookEditScreenMixin extends Screen {
1818
@Shadow

src/client/java/dev/isxander/debugify/client/mixins/basic/mc61489/BookViewScreenMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import org.spongepowered.asm.mixin.injection.ModifyArg;
1616

1717
// Compared to the original patch, we use / 3 here since it seems to line up better. Else, in a windowed screen the Done button appears at the very bottom / slightly off-screen.
18-
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, modConflicts = {"fixbookgui", "scribble"}, description = "Book GUI is not vertically centered")
18+
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, enabled = false, modConflicts = {"fixbookgui", "stendhal", "scribble"}, description = "Book GUI is not vertically centered")
1919
@Mixin(BookViewScreen.class)
2020
public class BookViewScreenMixin extends Screen {
2121
@Shadow

src/client/java/dev/isxander/debugify/client/mixins/basic/mc61489/LecternScreenMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.spongepowered.asm.mixin.injection.ModifyArg;
1010

1111
// Compared to the original patch, we use / 3 here since it seems to line up better. Else, in a windowed screen the Done button appears at the very bottom / slightly off-screen.
12-
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, modConflicts = {"fixbookgui", "scribble"}, description = "Book GUI is not vertically centered")
12+
@BugFix(id = "MC-61489", category = FixCategory.BASIC, env = BugFix.Env.CLIENT, enabled = false, modConflicts = {"fixbookgui", "stendhal", "scribble"}, description = "Book GUI is not vertically centered")
1313
@Mixin(LecternScreen.class)
1414
public class LecternScreenMixin extends BookViewScreen {
1515
@ModifyArg(method = "createMenuControls", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/components/Button$Builder;bounds(IIII)Lnet/minecraft/client/gui/components/Button$Builder;"), index = 1)

src/main/resources/assets/debugify/lang/en_us.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
"debugify.fix_explanation.mc-46503": "Clears shader effects on respawn.",
3535
"debugify.fix_explanation.mc-55347": "Clears titles on disconnect.",
36+
"debugify.fix_explanation.mc-61489": "Disabled by default because some players or mods might prefer the original book GUI position.",
3637
"debugify.fix_explanation.mc-79545": "Clamps the experience level to the integer limit only when rendering.",
3738
"debugify.fix_explanation.mc-93384": "Adds the eye height to the particle spawn location.",
3839
"debugify.fix_explanation.mc-105068": "Make shield break sound a local sound.",

0 commit comments

Comments
 (0)