Fixed InstantStateManager (#293)

- Added new test instantBoolean
- Added new test category
- Fixed test mod for fabric

Author: LopyMine

src/main/java/dev/isxander/yacl3/impl/InstantStateManager.java

@@ -3,59 +3,68 @@
 import dev.isxander.yacl3.api.Binding;
 import dev.isxander.yacl3.api.StateManager;
 
-import java.util.Objects;
-
 public class InstantStateManager<T> implements StateManager<T>, ProvidesBindingForDeprecation<T> {
-    private final Binding<T> binding;
-    private StateListener<T> stateListener;
+
+	private final Binding<T> binding;
+	private final T previousValue;
+	private T pendingValue;
+	private StateListener<T> stateListener;
+	private boolean requiresSave = false;
 
     public InstantStateManager(Binding<T> binding) {
-        this.binding = binding;
-        this.stateListener = StateListener.noop();
+	    this.binding = binding;
+	    this.previousValue = binding.getValue();
+	    this.pendingValue = binding.getValue();
+	    this.stateListener = StateListener.noop();
     }
 
     @Override
     public void set(T value) {
-        boolean changed = !Objects.equals(this.get(), value);
-
-        this.binding.setValue(value);
-
-        if (changed) stateListener.onStateChange(this.get(), value);
+	    boolean changed = !this.pendingValue.equals(value);
+	    boolean previousValue = this.previousValue.equals(value);
+
+	    this.binding.setValue(value);
+	    this.pendingValue = value;
+
+	    if (previousValue) {
+		    this.requiresSave = false;
+	    }
+	    if (changed && !previousValue) {
+		    this.requiresSave = true;
+	    }
+	    if (changed) {
+		    this.stateListener.onStateChange(this.pendingValue, value);
+	    }
     }
 
     @Override
     public T get() {
-        return this.binding.getValue();
+	    return this.pendingValue;
     }
 
     @Override
     public void apply() {
-        // no-op, state is always applied
+	    this.requiresSave = false;
     }
 
     @Override
     public void resetToDefault(ResetAction action) {
-        this.set(binding.defaultValue());
+	    this.set(this.binding.defaultValue());
     }
 
     @Override
     public void sync() {
-        // no-op, state is always synced
+	    this.set(this.previousValue);
     }
 
     @Override
     public boolean isSynced() {
-        return true;
-    }
-
-    @Override
-    public boolean isAlwaysSynced() {
-        return true;
+	    return !this.requiresSave;
     }
 
     @Override
     public boolean isDefault() {
-        return binding.defaultValue().equals(this.get());
+	    return this.binding.defaultValue().equals(this.pendingValue);
     }
 
     @Override
@@ -65,6 +74,6 @@ public void addListener(StateListener<T> stateListener) {
 
     @Override
     public Binding<T> getBinding() {
-        return binding;
+        return this.binding;
     }
 }

src/testmod/java/dev/isxander/yacl3/test/ConfigTest.java

@@ -82,6 +82,9 @@ public class ConfigTest {
     @SerialEntry
     public int scrollingSlider = 0;
 
+	@SerialEntry
+	public boolean instantBoolean;
+
     public enum Alphabet {
         A, B, C
     }

src/testmod/java/dev/isxander/yacl3/test/Entrypoint.java

@@ -1,4 +1,15 @@
-/*? if neoforge {*/
+/*? if fabric {*/
+package dev.isxander.yacl3.test;
+import net.fabricmc.api.ClientModInitializer;
+
+public class Entrypoint implements ClientModInitializer {
+	@Override
+	public void onInitializeClient() {
+
+	}
+}
+
+/*?} elif neoforge {*/
 /*package dev.isxander.yacl3.test;
 
 import net.neoforged.fml.common.Mod;

src/testmod/java/dev/isxander/yacl3/test/GuiTest.java

@@ -466,6 +466,7 @@ private static Screen getFullTestSuite(Screen parent) {
                                         .build())
                                 .build())
                         .category(sharedStateCategory())
+				        .category(instantStateManager(defaults, config))
                         .category(ConfigCategory.createBuilder()
                                 .name(Component.literal("Category Test"))
                                 .option(LabelOption.create(Component.literal("This is a test category!")))
@@ -571,6 +572,19 @@ private static ConfigCategory sharedStateCategory() {
         return builder.build();
     }
 
+	private static ConfigCategory instantStateManager(ConfigTest defaults, ConfigTest config) {
+		ConfigCategory.Builder builder = ConfigCategory.createBuilder()
+				.name(Component.literal("InstantStateManager Test"));
+
+		builder.option(Option.<Boolean>createBuilder()
+				.name(Component.literal("Instant Boolean"))
+				.stateManager(StateManager.createInstant(Binding.generic(defaults.instantBoolean, () -> config.instantBoolean, (bl) -> config.instantBoolean = bl)))
+				.controller(BooleanControllerBuilder::create)
+				.build());
+
+		return builder.build();
+	}
+
     private static ResourceLocation imageSample(String name) {
         return YACLPlatform.rl("yacl_test", "textures/images/" + name);
     }

src/testmod/resources/fabric.mod.json

@@ -22,7 +22,7 @@
   ],
   "entrypoints": {
     "client": [
-      "dev.isxander.yacl3.platform.PlatformEntrypoint"
+      "dev.isxander.yacl3.test.Entrypoint"
     ]
   },
   "custom": {