Skip to content

Commit bcce498

Browse files
committed
Merge branch 'cvolk/fix/stop_evaluation_on_error' into cvolk/feature/video_grid_droid_pnp
2 parents 9f1e1cb + 7fe4b83 commit bcce498

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

isaaclab_arena/evaluation/eval_runner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,11 @@ def main():
158158
metrics_logger.append_job_metrics(job.name, metrics)
159159

160160
except Exception as e:
161-
# continue with the next job even if one fails
162161
job_manager.complete_job(job, metrics={}, status=Status.FAILED)
163162
print(f"Job {job.name} failed with error: {e}")
164163
print(f"Traceback: {traceback.format_exc()}")
164+
if not args_cli.continue_on_error:
165+
raise
165166

166167
finally:
167168
# Only stop env if it was successfully created

isaaclab_arena/evaluation/eval_runner_cli.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,9 @@ def add_eval_runner_arguments(parser: argparse.ArgumentParser) -> None:
2121
default="/eval/videos",
2222
help="Root directory for recorded videos. Each job gets a subdirectory.",
2323
)
24+
parser.add_argument(
25+
"--continue_on_error",
26+
action="store_true",
27+
default=False,
28+
help="Continue evaluation with remaining jobs when a job fails instead of stopping immediately.",
29+
)

0 commit comments

Comments
 (0)