Skip to content

Commit 052975a

Browse files
authored
Sets default clipping mode for cameras to None (#1559)
# Description In #891, the `depth_clipping_behavior` parameter was added with the default mode set to `"zero"`. This introduced a breaking behavior in the depth cameras as previously, values returned by the cameras were not clipped. This PR sets the default behavior to `"none"`, which should bring us back to the original camera behavior. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 71df868 commit 052975a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/camera/camera_cfg.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ class OffsetCfg:
5353
asset is already present in the scene.
5454
"""
5555

56-
depth_clipping_behavior: Literal["max", "zero", "none"] = "zero"
57-
"""Clipping behavior for the camera for values exceed the maximum value. Defaults to "zero".
56+
depth_clipping_behavior: Literal["max", "zero", "none"] = "none"
57+
"""Clipping behavior for the camera for values exceed the maximum value. Defaults to "none".
5858
5959
- ``"max"``: Values are clipped to the maximum value.
6060
- ``"zero"``: Values are clipped to zero.

source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/ray_caster_camera_cfg.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ class OffsetCfg:
4646
data_types: list[str] = ["distance_to_image_plane"]
4747
"""List of sensor names/types to enable for the camera. Defaults to ["distance_to_image_plane"]."""
4848

49-
depth_clipping_behavior: Literal["max", "zero", "none"] = "zero"
50-
"""Clipping behavior for the camera for values exceed the maximum value. Defaults to "zero".
49+
depth_clipping_behavior: Literal["max", "zero", "none"] = "none"
50+
"""Clipping behavior for the camera for values exceed the maximum value. Defaults to "none".
5151
5252
- ``"max"``: Values are clipped to the maximum value.
5353
- ``"zero"``: Values are clipped to zero.

0 commit comments

Comments
 (0)