Skip to content

Commit 0d1725e

Browse files
kellyguo11ooctipus
andauthored
Updates github actions to error on doc warnings (#3488)
# Description Some more infrastructure updates to brush up our automated jobs: - treat warnings as errors in doc building and fixing some existing warnings - adding release branches to the doc versions - making sure all jobs also get triggered on release branches - fixes make script on windows - fixes out of space error for license check job ## Type of change - Documentation update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: ooctipus <[email protected]>
1 parent 6792181 commit 0d1725e

File tree

9 files changed

+52
-22
lines changed

9 files changed

+52
-22
lines changed

.github/workflows/docs.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ on:
1010
branches:
1111
- main
1212
- devel
13+
- 'release/**'
1314
pull_request:
1415
types: [opened, synchronize, reopened]
1516

@@ -27,8 +28,7 @@ jobs:
2728
- id: trigger-deploy
2829
env:
2930
REPO_NAME: ${{ secrets.REPO_NAME }}
30-
BRANCH_REF: ${{ secrets.BRANCH_REF }}
31-
if: "${{ github.repository == env.REPO_NAME && github.ref == env.BRANCH_REF }}"
31+
if: "${{ github.repository == env.REPO_NAME && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/devel' || startsWith(github.ref, 'refs/heads/release/')) }}"
3232
run: echo "defined=true" >> "$GITHUB_OUTPUT"
3333

3434
build-docs:

.github/workflows/license-check.yaml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,20 @@ jobs:
2424
# - name: Install jq
2525
# run: sudo apt-get update && sudo apt-get install -y jq
2626

27+
- name: Clean up disk space
28+
run: |
29+
rm -rf /opt/hostedtoolcache
30+
2731
- name: Set up Python
2832
uses: actions/setup-python@v4
2933
with:
30-
python-version: '3.10' # Adjust as needed
34+
python-version: '3.11' # Adjust as needed
3135

3236
- name: Install dependencies using ./isaaclab.sh -i
3337
run: |
3438
# first install isaac sim
3539
pip install --upgrade pip
36-
pip install 'isaacsim[all,extscache]==4.5.0' --extra-index-url https://pypi.nvidia.com
40+
pip install 'isaacsim[all,extscache]==${{ vars.ISAACSIM_BASE_VERSION || '5.0.0' }}' --extra-index-url https://pypi.nvidia.com
3741
chmod +x ./isaaclab.sh # Make sure the script is executable
3842
# install all lab dependencies
3943
./isaaclab.sh -i
@@ -48,6 +52,12 @@ jobs:
4852
- name: Print License Report
4953
run: pip-licenses --from=mixed --format=markdown
5054

55+
# Print pipdeptree
56+
- name: Print pipdeptree
57+
run: |
58+
pip install pipdeptree
59+
pipdeptree
60+
5161
- name: Check licenses against whitelist and exceptions
5262
run: |
5363
# Define the whitelist of allowed licenses
@@ -118,9 +128,3 @@ jobs:
118128
else
119129
echo "All packages were checked."
120130
fi
121-
122-
# Print pipdeptree
123-
- name: Print pipdeptree
124-
run: |
125-
pip install pipdeptree
126-
pipdeptree

.github/workflows/license-exceptions.json

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@
308308
},
309309
{
310310
"package": "typing_extensions",
311-
"license": "UNKNOWN",
311+
"license": "Python Software Foundation License",
312312
"comment": "PSFL / OSRB"
313313
},
314314
{
@@ -400,5 +400,30 @@
400400
"package": "fsspec",
401401
"license" : "UNKNOWN",
402402
"comment": "BSD"
403+
},
404+
{
405+
"package": "numpy-quaternion",
406+
"license": "UNKNOWN",
407+
"comment": "MIT"
408+
},
409+
{
410+
"package": "aiohappyeyeballs",
411+
"license": "Other/Proprietary License; Python Software Foundation License",
412+
"comment": "PSFL / OSRB"
413+
},
414+
{
415+
"package": "cffi",
416+
"license": "UNKNOWN",
417+
"comment": "MIT"
418+
},
419+
{
420+
"package": "trio",
421+
"license": "UNKNOWN",
422+
"comment": "MIT"
423+
},
424+
{
425+
"package": "pipdeptree",
426+
"license": "UNKNOWN",
427+
"comment": "MIT"
403428
}
404429
]

.github/workflows/pre-commit.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ name: Run linters using pre-commit
77

88
on:
99
pull_request:
10-
push:
11-
branches: [main]
10+
types: [opened, synchronize, reopened]
1211

1312
jobs:
1413
pre-commit:

docs/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ multi-docs:
1515

1616
.PHONY: current-docs
1717
current-docs:
18-
@$(SPHINXBUILD) "$(SOURCEDIR)" "$(BUILDDIR)/current" $(SPHINXOPTS)
18+
@rm -rf "$(BUILDDIR)/current"
19+
@$(SPHINXBUILD) -W --keep-going "$(SOURCEDIR)" "$(BUILDDIR)/current" $(SPHINXOPTS)

docs/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@
282282
# Whitelist pattern for remotes
283283
smv_remote_whitelist = r"^.*$"
284284
# Whitelist pattern for branches (set to None to ignore all branches)
285-
smv_branch_whitelist = os.getenv("SMV_BRANCH_WHITELIST", r"^(main|devel)$")
285+
smv_branch_whitelist = os.getenv("SMV_BRANCH_WHITELIST", r"^(main|devel|release/.*)$")
286286
# Whitelist pattern for tags (set to None to ignore all tags)
287287
smv_tag_whitelist = os.getenv("SMV_TAG_WHITELIST", r"^v[1-9]\d*\.\d+\.\d+$")
288288
html_sidebars = {

docs/make.bat

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ if "%1" == "multi-docs" (
1313
if "%SPHINXBUILD%" == "" (
1414
set SPHINXBUILD=sphinx-multiversion
1515
)
16-
%SPHINXBUILD% >NUL 2>NUL
17-
if errorlevel 9009 (
16+
where %SPHINXBUILD% >NUL 2>NUL
17+
if errorlevel 1 (
1818
echo.
1919
echo.The 'sphinx-multiversion' command was not found. Make sure you have Sphinx
2020
echo.installed, then set the SPHINXBUILD environment variable to point
@@ -37,8 +37,8 @@ if "%1" == "current-docs" (
3737
if "%SPHINXBUILD%" == "" (
3838
set SPHINXBUILD=sphinx-build
3939
)
40-
%SPHINXBUILD% >NUL 2>NUL
41-
if errorlevel 9009 (
40+
where %SPHINXBUILD% >NUL 2>NUL
41+
if errorlevel 1 (
4242
echo.
4343
echo.The 'sphinx-build' command was not found. Make sure you have Sphinx
4444
echo.installed, then set the SPHINXBUILD environment variable to point
@@ -49,7 +49,8 @@ if "%1" == "current-docs" (
4949
echo.http://sphinx-doc.org/
5050
exit /b 1
5151
)
52-
%SPHINXBUILD% %SOURCEDIR% %BUILDDIR%\current %SPHINXOPTS% %O%
52+
if exist "%BUILDDIR%\current" rmdir /s /q "%BUILDDIR%\current"
53+
%SPHINXBUILD% -W "%SOURCEDIR%" "%BUILDDIR%\current" %SPHINXOPTS%
5354
goto end
5455
)
5556

docs/source/api/lab/isaaclab.assets.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Asset Base
3232

3333
.. autoclass:: AssetBaseCfg
3434
:members:
35-
:exclude-members: __init__, class_type
35+
:exclude-members: __init__, class_type, InitialStateCfg
3636

3737
Rigid Object
3838
------------

docs/source/api/lab/isaaclab.sensors.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ USD Camera
6161
:members:
6262
:inherited-members:
6363
:show-inheritance:
64-
:exclude-members: __init__, class_type
64+
:exclude-members: __init__, class_type, OffsetCfg
6565

6666
Tile-Rendered USD Camera
6767
------------------------

0 commit comments

Comments
 (0)