Skip to content

Commit 1e3b6ec

Browse files
authored
Fixes net_arch in sb3_ppo_cfg.yaml for Isaac-Lift-Cube-Franka-v0 task (#1249)
# Description Two changes are made to fix _[Bug Report] sb3_ppo_cfg.yaml not work for Isaac-Lift-Cube-Franka-v0 #1248_: 1. Add `sb3_cfg_entry_point` to `source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka/init.py` 2. Change `net_arch=[32, 32, dict(pi=[256, 128, 64], vf=[256, 128, 64])]` to `net_arch=dict(pi=[256, 128, 64], vf=[256, 128, 64])` in line 19 of `sb3_ppo_cfg.yaml`. Fixes #1248 ## Type of change - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] My changes generate no new warnings
1 parent c8f77a7 commit 1e3b6ec

File tree

2 files changed

+3
-1
lines changed
  • source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka

2 files changed

+3
-1
lines changed

source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"rsl_rl_cfg_entry_point": f"{agents.__name__}.rsl_rl_ppo_cfg:LiftCubePPORunnerCfg",
2424
"skrl_cfg_entry_point": f"{agents.__name__}:skrl_ppo_cfg.yaml",
2525
"rl_games_cfg_entry_point": f"{agents.__name__}:rl_games_ppo_cfg.yaml",
26+
"sb3_cfg_entry_point": f"{agents.__name__}:sb3_ppo_cfg.yaml",
2627
},
2728
disable_env_checker=True,
2829
)
@@ -35,6 +36,7 @@
3536
"rsl_rl_cfg_entry_point": f"{agents.__name__}.rsl_rl_ppo_cfg:LiftCubePPORunnerCfg",
3637
"skrl_cfg_entry_point": f"{agents.__name__}:skrl_ppo_cfg.yaml",
3738
"rl_games_cfg_entry_point": f"{agents.__name__}:rl_games_ppo_cfg.yaml",
39+
"sb3_cfg_entry_point": f"{agents.__name__}:sb3_ppo_cfg.yaml",
3840
},
3941
disable_env_checker=True,
4042
)

source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka/agents/sb3_ppo_cfg.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ learning_rate: !!float 3e-4
1616
clip_range: 0.2
1717
policy_kwargs: "dict(
1818
activation_fn=nn.ELU,
19-
net_arch=[32, 32, dict(pi=[256, 128, 64], vf=[256, 128, 64])]
19+
net_arch=dict(pi=[256, 128, 64], vf=[256, 128, 64])
2020
)"
2121
target_kl: 0.01
2222
max_grad_norm: 1.0

0 commit comments

Comments
 (0)