Skip to content

Commit c8e1d4e

Browse files
Fixes for custom dependency install failing due to typo in template generator (#3197)
# Description The [template generator](https://isaac-sim.github.io/IsaacLab/main/source/overview/developer-guide/template.html) is involved when project / task is created using ```./isaaclab.sh -n [Project Name]```. Inside the ```source``` directory in ```config/extension.toml``` file there is a provision to add custom apt or ros_ws dependency as mentioned [here](https://isaac-sim.github.io/IsaacLab/main/source/overview/developer-guide/development.html#custom-extension-dependency-management) which is current failing. The problem is result of a typo in the template generator extension config file which is current ```[isaaclab_settings]``` and should be ```[isaac_lab_settings]``` instead. The file is located at: ``` IsaacLab/tools/template/templates/extension/config/extension.toml ``` Fixes #3196 ## Type of change - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Screenshots | Before | After | | ------ | ----- | | <img width="591" height="201" alt="image" src="https://github.com/user-attachments/assets/57daa5a7-ba26-4f21-8749-14123470817e" /> | <img width="591" height="201" alt="image" src="https://github.com/user-attachments/assets/ddb129ad-cf84-474f-b87f-da5158981f56" />| ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
1 parent 90af2be commit c8e1d4e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ Guidelines for modifications:
133133
* Stefan Van de Mosselaer
134134
* Stephan Pleines
135135
* Tiffany Chen
136+
* Trushant Adeshara
136137
* Tyler Lum
137138
* Victor Khaustov
138139
* Virgilio Gómez Lambo

tools/template/templates/extension/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ keywords = ["extension", "template", "isaaclab"]
2525
[[python.module]]
2626
name = "{{ name }}"
2727

28-
[isaaclab_settings]
28+
[isaac_lab_settings]
2929
# TODO: Uncomment and list any apt dependencies here.
3030
# If none, leave it commented out.
3131
# apt_deps = ["example_package"]

0 commit comments

Comments
 (0)