Fixed notebook_dir to always be defined #234
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I installed the Jupyter Code Editor extension via the Isaac Sim CLI, which worked as expected. However when I try to change the notebook directory via
--/exts/isaacsim.code_editor.jupyter/notebook_diror the 'extension.toml' file, I get the below log statements:This error prevents the Jupyter Code Editor extension from starting
Solution
Add the bottom 2 lines to
IsaacSim/source/extensions/isaacsim.code_editor.jupyter/data/launchers/jupyter_launcher.py, line 109:Without the else statement, the notebook_dir variable is undefined when defining a notebook_dir via the CLI or extension.toml file, as argv[3] exists. This change was tested locally and allows for changing the Jupyter Notebook directory.
Isaac Sim version
5.0.0
Operating System (OS)
Ubuntu 24.04.3
GPU Name
RTX 3090 Ti
GPU Driver and CUDA versions
Driver Version: 570.172 Cuda: 12.8
Logs
Additional information