refactor: streamline date handling in vault and miniapp services

- Replaced manual date construction with a method to retrieve the current budget period in MiniappService, VaultWebService, and VaultService.
- Updated transaction retrieval logic to directly use provided date options, enhancing clarity and reducing redundancy in date management.

Author: isaacbatst

src/bot/miniapp.service.ts

@@ -239,12 +239,8 @@ export class MiniappService {
         });
       }
 
-      // Usar data customizada ou o mês atual
-      const now = new Date();
-      const date = customDate || {
-        month: now.getMonth() + 1,
-        year: now.getFullYear(),
-      };
+      // Usar data customizada ou o período de orçamento atual
+      const date = customDate || vault.getCurrentBudgetPeriod();
       const budget = vault.getBudgetsSummary(date.month, date.year);
 
       return right({
@@ -285,10 +281,7 @@ export class MiniappService {
     try {
       const transactionsResult = await this.vaultService.getTransactions({
         vaultId,
-        date: options.date || {
-          year: new Date().getFullYear(),
-          month: new Date().getMonth() + 1,
-        },
+        date: options.date,
         page: options.page || 1,
         categoryId: options.categoryId,
         description: options.description,

src/vault/domain/vault.ts

@@ -115,6 +115,17 @@ export class Vault {
     return date >= startDate && date <= endDate;
   }
 
+  getCurrentBudgetPeriod(): { month: number; year: number } {
+    const now = new Date();
+    let month = now.getMonth() + 1;
+    let year = now.getFullYear();
+    if (now.getDate() < this._budgetStartDay) {
+      month -= 1;
+      if (month < 1) { month = 12; year -= 1; }
+    }
+    return { month, year };
+  }
+
   static create(): Vault {
     return new Vault(Vault.generateId(), Vault.generateToken(), new Date());
   }
@@ -287,8 +298,7 @@ export class Vault {
   totalSpentAmount(date?: { month: number; year: number }): number {
     let total = 0;
     if (!date) {
-      const now = new Date();
-      date = { month: now.getMonth() + 1, year: now.getFullYear() };
+      date = this.getCurrentBudgetPeriod();
     }
 
     for (const transaction of this.transactions.values()) {
@@ -305,8 +315,7 @@ export class Vault {
   totalIncomeAmount(date?: { month: number; year: number }): number {
     let total = 0;
     if (!date) {
-      const now = new Date();
-      date = { month: now.getMonth() + 1, year: now.getFullYear() };
+      date = this.getCurrentBudgetPeriod();
     }
 
     for (const transaction of this.transactions.values()) {

src/vault/vault-web.service.ts

@@ -200,12 +200,8 @@ export class VaultWebService {
         });
       }
 
-      // Use custom date or current month
-      const now = new Date();
-      const targetDate = date || {
-        month: now.getMonth() + 1,
-        year: now.getFullYear(),
-      };
+      // Use custom date or current budget period
+      const targetDate = date || vault.getCurrentBudgetPeriod();
       const budget = vault.getBudgetsSummary(targetDate.month, targetDate.year);
 
       return right({
@@ -240,10 +236,7 @@ export class VaultWebService {
       // Use VaultService directly
       const [error, transactions] = await this.vaultService.getTransactions({
         vaultId,
-        date: params.date || {
-          year: new Date().getFullYear(),
-          month: new Date().getMonth() + 1,
-        },
+        date: params.date,
         page: params.page || 1,
         categoryId: params.categoryId,
         description: params.description,

src/vault/vault.service.ts

@@ -214,11 +214,7 @@ export class VaultService {
       return left(`Cofre não encontrado`);
     }
 
-    const now = new Date();
-    const date = input.date ?? {
-      month: now.getMonth() + 1,
-      year: now.getFullYear(),
-    };
+    const date = input.date ?? vault.getCurrentBudgetPeriod();
     const { startDate, endDate } = vault.getBudgetPeriod(date.month, date.year);
 
     const transactions =