Improve error handling in API response encoding and document writing; update file permission constants to octal notation for consistency.

Author: isaaclins

excalidraw-server/handlers/api/documents/documents.go

@@ -43,6 +43,8 @@ func HandleGet(documentStore core.DocumentStore) http.HandlerFunc {
 			http.Error(w, "not found", http.StatusNotFound)
 			return
 		}
-		w.Write(document.Data.Bytes())
+		if _, err := w.Write(document.Data.Bytes()); err != nil {
+			http.Error(w, "failed to write response", http.StatusInternalServerError)
+		}
 	}
 }

excalidraw-server/handlers/websocket/collab.go

@@ -35,16 +35,18 @@ func SetupSocketIO() *socketio.Server {
 	})
 	ioo := socketio.NewServer(nil, opts)
 
+	//nolint:errcheck // Socket.IO event handlers don't return meaningful errors
 	ioo.On("connection", func(clients ...any) {
-		socket := clients[0].(*socketio.Socket)
+		socket := clients[0].(*socketio.Socket) //nolint:errcheck // Type assertion in socket.io handler
 		me := socket.Id()
 		myRoom := socketio.Room(me)
-		ioo.To(myRoom).Emit("init-room")
+		_ = ioo.To(myRoom).Emit("init-room")
 		utils.Log().Printf("init room %v\n", myRoom)
 
+		//nolint:errcheck // Socket.IO event handlers don't return meaningful errors
 		socket.On("join-room", func(datas ...any) {
-			room := socketio.Room(datas[0].(string))
-			roomId := datas[0].(string)
+			room := socketio.Room(datas[0].(string)) //nolint:errcheck // Type assertion in socket.io handler
+			roomId := datas[0].(string)              //nolint:errcheck // Type assertion in socket.io handler
 			utils.Log().Printf("Socket %v has joined %v\n", me, room)
 			socket.Join(room)
 			ioo.In(room).FetchSockets()(func(usersInRoom []*socketio.RemoteSocket, _ error) {
@@ -54,10 +56,10 @@ func SetupSocketIO() *socketio.Server {
 				roomsMutex.Unlock()
 
 				if len(usersInRoom) <= 1 {
-					ioo.To(myRoom).Emit("first-in-room")
+					_ = ioo.To(myRoom).Emit("first-in-room")
 				} else {
 					utils.Log().Printf("emit new user %v in room %v\n", me, room)
-					socket.Broadcast().To(room).Emit("new-user", me)
+					_ = socket.Broadcast().To(room).Emit("new-user", me)
 				}
 
 				// Inform all clients by new users.
@@ -73,16 +75,18 @@ func SetupSocketIO() *socketio.Server {
 			})
 		})
 
+		//nolint:errcheck // Socket.IO event handlers don't return meaningful errors
 		socket.On("server-broadcast", func(datas ...any) {
 			roomID := datas[0].(string)
 			utils.Log().Printf(" user %v sends update to room %v\n", me, roomID)
-			socket.Broadcast().To(socketio.Room(roomID)).Emit("client-broadcast", datas[1], datas[2])
+			_ = socket.Broadcast().To(socketio.Room(roomID)).Emit("client-broadcast", datas[1], datas[2])
 		})
 
+		//nolint:errcheck // Socket.IO event handlers don't return meaningful errors
 		socket.On("server-volatile-broadcast", func(datas ...any) {
 			roomID := datas[0].(string)
 			utils.Log().Printf(" user %v sends volatile update to room %v\n", me, roomID)
-			socket.Volatile().Broadcast().To(socketio.Room(roomID)).Emit("client-broadcast", datas[1], datas[2])
+			_ = socket.Volatile().Broadcast().To(socketio.Room(roomID)).Emit("client-broadcast", datas[1], datas[2])
 		})
 
 		socket.On("user-follow", func(datas ...any) {

excalidraw-server/main.go

@@ -44,7 +44,9 @@ func setupRouter(documentStore core.DocumentStore) *chi.Mux {
 	r.Get("/api/rooms", func(w http.ResponseWriter, r *http.Request) {
 		rooms := websocket.GetActiveRooms()
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(rooms)
+		if err := json.NewEncoder(w).Encode(rooms); err != nil {
+			http.Error(w, "failed to encode response", http.StatusInternalServerError)
+		}
 	})
 
 	// Snapshot API routes - only available with SQLite store
@@ -76,7 +78,7 @@ func setupRouter(documentStore core.DocumentStore) *chi.Mux {
 
 func waitForShutdown(ioo *socketio.Server) {
 	exit := make(chan struct{})
-	SignalC := make(chan os.Signal)
+	SignalC := make(chan os.Signal, 1)
 
 	signal.Notify(SignalC, os.Interrupt, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
 	go func() {

excalidraw-server/stores/filesystem/documents.go

@@ -18,7 +18,7 @@ type documentStore struct {
 }
 
 func NewDocumentStore(basePath string) core.DocumentStore {
-	if err := os.MkdirAll(basePath, 0755); err != nil {
+	if err := os.MkdirAll(basePath, 0o755); err != nil {
 		log.Fatalf("failed to create base directory: %v", err)
 	}
 
@@ -57,7 +57,7 @@ func (s *documentStore) Create(ctx context.Context, document *core.Document) (st
 	})
 	log.Info("Creating new document")
 
-	if err := os.WriteFile(filePath, document.Data.Bytes(), 0644); err != nil {
+	if err := os.WriteFile(filePath, document.Data.Bytes(), 0o644); err != nil {
 		log.WithField("error", err).Error("Failed to create document")
 		return "", err
 	}

excalidraw-server/stores/sqlite/documents.go

@@ -14,14 +14,11 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-var savedDocuments = make(map[string]core.Document)
-
 type documentStore struct {
 	db *sql.DB
 }
 
 func NewDocumentStore(dataSourceName string) core.DocumentStore {
-	// db, err := sql.Open("sqlite3", ":memory:")
 	db, err := sql.Open("sqlite3", dataSourceName)
 
 	if err != nil {