Skip to content

Commit a881c08

Browse files
Merge pull request #135 from isaqb-org/132-improve-release-handling
2 parents d4bf7b5 + 7502e32 commit a881c08

File tree

7 files changed

+35
-18
lines changed

7 files changed

+35
-18
lines changed

.github/workflows/build_main.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,21 @@ jobs:
3131
with:
3232
distribution: 'temurin'
3333
java-version: 17
34-
- name: Execute Gradle Build
35-
uses: eskatos/gradle-command-action@v2
36-
with:
37-
# Gradle command line arguments, see gradle --help
38-
gradle-version: 7.5.1
39-
arguments: buildDocs
4034

41-
# do the following two things only for a release!
35+
# If we're building a release, we need to set the variable RELEASE_VERSION
4236
- name: Set Environment Variables for Release Version
4337
if: startsWith(github.ref, 'refs/tags/')
4438
run: echo "RELEASE_VERSION=${GITHUB_REF:10}" >> $GITHUB_ENV
39+
40+
- name: Execute Gradle Build
41+
uses: gradle/gradle-build-action@v2
42+
env:
43+
CI: true
44+
with:
45+
gradle-version: wrapper
46+
arguments: buildDocs
47+
48+
# release and deploy only if we're building a release
4549
- name: Prepare Deployment
4650
if: startsWith(github.ref, 'refs/tags/')
4751
run: |

.github/workflows/build_pr.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ jobs:
3030
distribution: 'temurin'
3131
java-version: 17
3232
- name: Execute Gradle Build
33-
uses: eskatos/gradle-command-action@v2
33+
uses: gradle/gradle-build-action@v2
3434
with:
35-
# Gradle command line arguments, see gradle --help
36-
gradle-version: 7.5.1
35+
gradle-version: wrapper
3736
arguments: buildDocs

.github/workflows/build_releasecandidate.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,18 @@ jobs:
3434
with:
3535
distribution: 'temurin'
3636
java-version: 17
37+
38+
# If we're building a release, we need to set the variable RELEASE_VERSION
39+
- name: Set Environment Variables for Release Version
40+
if: startsWith(github.ref, 'refs/tags/')
41+
run: echo "RELEASE_VERSION=${GITHUB_REF:10}" >> $GITHUB_ENV
42+
3743
- name: Execute Gradle Build
38-
uses: eskatos/gradle-command-action@v2
44+
uses: gradle/gradle-build-action@v2
45+
env:
46+
CI: true
3947
with:
40-
# Gradle command line arguments, see gradle --help
41-
gradle-version: 7.5.1
48+
gradle-version: wrapper
4249
arguments: buildDocs
4350

4451
# do the following two things only for a release!

CHANGELOG.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
1-
# New in 2020.6
1+
# Release Notes
2+
## New in 2020.7
3+
- Remove lots of old/unused stuff regarding remarks
4+
- Use Gradle Wrapper in GitHub Actions
5+
- Take document version from git tag
6+
7+
## New in 2020.6
28

39
- CHANGELOG can be created from file
410
- Use new and simplified release action
511
- Update to latest Aciidoctor versions
6-
- Update to latest Gradle
12+
- Update to latest Gradle (7.5.1)

README.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ git clone https://github.com/isaqb-org/advanced-template.git --recursive
5252
. Open the file `build.gradle` to adjust attributes specific to your curriculum:
5353
[loweralpha]
5454
.. `curriculumFileName`: the name of the asciidoc root file of your curriculum e.g. `curriculum-flex` (see above! The `.adoc` suffix is added automatically, omit it here!)
55-
. Edit the file `document.version` and enter the version number this new version of the curriculum shall have e.g. "2020.1".
5655
. Open README.adoc and replace the string `curriculum-template` with the name of your Github repository e.g. `curriculum-flex`
5756
. Build the project with http://www.gradle.com[gradle] (you need a locally installed JDK) via `./gradlew`.
5857
. Once the "BUILD SUCCESSFUL" is show, you can review the build result under `./build/index.html`

build.gradle

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ ext {
1818
today = new Date()
1919
versionDate = new SimpleDateFormat("yyyyMMdd").format(today)
2020

21-
project.version = project.file("./document.version").text
21+
releaseVersion = System.getenv("RELEASE_VERSION")
22+
localVersion = "LocalBuild"
23+
project.version = releaseVersion == null ? localVersion : releaseVersion;
24+
2225
curriculumFileName = "curriculum-template"
2326
addSuffixToCurriculum = { suffix ->
2427
for (extension in ["html", "pdf"]) {

document.version

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)