Merge pull request intersystems-community#674 from isc-bsaviano/master

Improve compilation error handling

Author: isc-bsaviano

src/api/index.ts

@@ -362,7 +362,7 @@ export class AtelierAPI {
 
       // Handle any errors
       if (data.status.summary !== "") {
-        // This is a 500 server error or a query request with malformed SQL
+        // This is a 500 server error, a query request with malformed SQL or a failed compile (which will have a 200 OK status)
         throw { statusCode: response.status, message: response.statusText, errorText: data.status.summary };
       }
       if (data.result.status && data.result.status !== "") {

src/commands/compile.ts

@@ -229,12 +229,12 @@ async function compile(docs: CurrentFile[], flags?: string): Promise<any> {
             return docs;
           })
           .catch((error: Error) => {
-            outputChannel.appendLine(error.message);
-            outputChannel.show(true);
             if (!config("suppressCompileErrorMessages")) {
-              vscode.window.showErrorMessage(error.message, "Show details").then((data) => {
-                outputChannel.show(true);
-              });
+              vscode.window
+                .showErrorMessage("Compilation failed. Check output channel for details.", "Dismiss")
+                .then((data) => {
+                  outputChannel.show(true);
+                });
             }
             // Even when compile failed we should still fetch server changes
             return docs;