Fix dns_fwdtable_addfwd() error path cleanup bug

Aram Sargsyan · Arаm Sаrgsyаn · commit 0cc1b06d9867 · 2023-01-11T12:41:06.000Z
Free 'sizeof(dns_forwarder_t)' bytes of memory instead of
'sizeof(dns_sockaddr_t)' bytes, because `fwd` is a pointer
to a 'dns_forwarder_t' type structure.
diff --git a/lib/dns/forward.c b/lib/dns/forward.c
@@ -103,7 +103,7 @@ dns_fwdtable_addfwd(dns_fwdtable_t *fwdtable, const dns_name_t *name,
 	while (!ISC_LIST_EMPTY(forwarders->fwdrs)) {
 		fwd = ISC_LIST_HEAD(forwarders->fwdrs);
 		ISC_LIST_UNLINK(forwarders->fwdrs, fwd, link);
-		isc_mem_put(fwdtable->mctx, fwd, sizeof(isc_sockaddr_t));
+		isc_mem_put(fwdtable->mctx, fwd, sizeof(dns_forwarder_t));
 	}
 	isc_mem_put(fwdtable->mctx, forwarders, sizeof(dns_forwarders_t));
 	return (result);

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ dns_fwdtable_addfwd(dns_fwdtable_t fwdtable, const dns_name_t name,`
`103`	`103`	`while (!ISC_LIST_EMPTY(forwarders->fwdrs)) {`
`104`	`104`	`fwd = ISC_LIST_HEAD(forwarders->fwdrs);`
`105`	`105`	`ISC_LIST_UNLINK(forwarders->fwdrs, fwd, link);`
`106`		`- isc_mem_put(fwdtable->mctx, fwd, sizeof(isc_sockaddr_t));`
	`106`	`+ isc_mem_put(fwdtable->mctx, fwd, sizeof(dns_forwarder_t));`
`107`	`107`	`}`
`108`	`108`	`isc_mem_put(fwdtable->mctx, forwarders, sizeof(dns_forwarders_t));`
`109`	`109`	`return (result);`