Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Commit 4203e16

Browse files
committed
Merge branch 'mnowak/danger-test-pairwise-hint' into 'main'
Add a friendly Danger plea to run the pairwise CI job See merge request isc-projects/bind9!7876
2 parents 07d2684 + 96563c6 commit 4203e16

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

dangerfile.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,11 +398,19 @@ def lines_containing(lines, string):
398398
configure_added_lines, "AC_ARG_ENABLE"
399399
) + lines_containing(configure_added_lines, "AC_ARG_WITH")
400400
annotations_added = lines_containing(configure_added_lines, "# [pairwise: ")
401-
if len(switches_added) > len(annotations_added):
402-
fail(
403-
"This merge request adds at least one new `./configure` switch that "
404-
"is not annotated for pairwise testing purposes."
405-
)
401+
if switches_added:
402+
if len(switches_added) > len(annotations_added):
403+
fail(
404+
"This merge request adds at least one new `./configure` switch that "
405+
"is not annotated for pairwise testing purposes."
406+
)
407+
else:
408+
message(
409+
"**Before merging**, please start a full CI pipeline for this "
410+
"branch with the `PAIRWISE_TESTING` variable set to any "
411+
"non-empty value (e.g. `1`). This will cause the `pairwise` "
412+
"job to exercise the new `./configure` switches."
413+
)
406414

407415
###############################################################################
408416
# USER-VISIBLE LOG LEVELS

0 commit comments

Comments
 (0)