[#3256] address review

andrei-pavel · andrei-pavel · commit 42bd2b586707 · 2024-05-20T23:28:51.000+03:00
diff --git a/src/lib/cc/data.cc b/src/lib/cc/data.cc
@@ -902,7 +902,7 @@ StringElement::toJSON(std::ostream& ss) const {
             ss << '\\' << 't';
             break;
         default:
-            if (((c >= 0) && (c < 0x20)) || (c < 0) || (c >= 0x7f)) {
+            if (c < 0x20 || c == 0x7f) {
                 std::ostringstream esc;
                 esc << "\\u"
                     << hex
diff --git a/src/lib/http/http_message_parser_base.cc b/src/lib/http/http_message_parser_base.cc
@@ -262,7 +262,6 @@ HttpMessageParserBase::popNextFromBuffer(std::string& next, const size_t limit)
 
 bool
 HttpMessageParserBase::isChar(const signed char c) const {
-    // was (c >= 0) && (c <= 127)
     return (c >= 0);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,6 @@ HttpMessageParserBase::popNextFromBuffer(std::string& next, const size_t limit)`
`262`	`262`
`263`	`263`	`bool`
`264`	`264`	`HttpMessageParserBase::isChar(const signed char c) const {`
`265`		`- // was (c >= 0) && (c <= 127)`
`266`	`265`	`return (c >= 0);`
`267`	`266`	`}`
`268`	`267`