[#3732] Address review

Author: andrei-pavel

CONTRIBUTING.md

@@ -191,7 +191,7 @@ such long periods, code tends to be refactored several times. The change you mad
 some other change or by the code that hasn't been written yet.
 
 See Building Kea with Unit Tests for instructions on how to run unit-tests. If you happen to touch
-any database related code, make sure you compile your code with `–Dmysql` and/or `–Dpostgresql` as
+any database related code, make sure you compile your code with `–D mysql=enabled` and/or `–D postgresql=enabled` as
 needed. For example, if you change something substantial, make sure the other compilation options
 still work.
 
@@ -200,7 +200,7 @@ various additional consistency checks that reduce performance but help during de
 
 If you are modifying DHCP code, you are likely to be interested in enabling a non-default database backends for DHCP.
 Note that if the backend is not enabled, the database-specific unit-tests are skipped.  To
-enable the MySQL backend, use the switch `-Dmysql`; for PostgreSQL, use `–Dpostgresql`.
+enable the MySQL backend, use the switch `-D mysql=enabled`; for PostgreSQL, use `–D postgresql=enabled`.
 A complete list of all switches can be obtained with the command:
 
 ```bash

INSTALL

@@ -7,9 +7,9 @@ PostgreSQL), you will need to specify these as options to the command (run
 
    $ meson setup build
 
-If your environment is missing dependencies, the configure script will exit
+If your environment is missing dependencies, the command will exit
 with error and should emit sufficient information to guide you on how to
-proceed. A detailed account of the configure process is captured in
+proceed. A detailed account of the setup process is captured in
 build/meson-logs/meson-log.txt.
 
 2. Build it. Once you've successfully set up the build, run "meson compile" to

doc/devel/Makefile.am

@@ -5,7 +5,6 @@ EXTRA_DIST += changelog.dox
 EXTRA_DIST += config-backend.dox
 EXTRA_DIST += congestion-handling.dox
 EXTRA_DIST += contribute.dox
-EXTRA_DIST += cross-compile.dox
 EXTRA_DIST += debug.dox
 EXTRA_DIST += doc.dox
 EXTRA_DIST += fuzz.dox

doc/devel/cross-compile.dox

@@ -10,8 +10,7 @@
 
  There are several types of documentation for Kea. The primary one, intended to
  be read by users, is User's Guide. It comes in HTML, PDF and txt format. All
- of them generated from the same sources. To generate this doc, you need to
- run configure script with --enable-generate-docs option. sphinx and
+ of them generated from the same sources. To generate the documentation, sphinx and
  sphinx_rtd_theme have to be available on the system. texlive is also required
  if you want to create documentation in HTML format.
  You can generate this by doing:

doc/devel/doc.dox

@@ -46,7 +46,7 @@ Combining the binaries and the fuzzer types results in eight fuzzing binaries:
 
 @subsection HowToBuild How to Build the LLVM Fuzzer
 
-Use the "--enable-fuzzing" during the configure step. Then just compile as usual.
+Use the "-D fuzz=enabled" during the meson setup step. Then just compile as usual.
 
 @code
 meson setup build -D fuzz=enabled
@@ -171,7 +171,7 @@ for this are:
      compiler.
    - Specify a value of "--prefix" on the command line to set the directory
      into which Kea is installed.
-   - Add the "-Dfuzz=enabled" switch to the "meson setup" command line.
+   - Add the "-D fuzz=enabled" switch to the "meson setup" command line.
    .
    For example:
    @code
@@ -327,7 +327,7 @@ while (not shutting down) {
     Read and process one packet
 }
 @endcode
-When -Dfuzz=enabled is specified, this is conceptually modified to:
+When -D fuzz=enabled is specified, this is conceptually modified to:
 @code{.unparsed}
 while (not shutting down) {
     Read stdin and copy data to address/port on which Kea is listening
@@ -374,7 +374,7 @@ leaks).
 No changes were required to Kea source code to fuzz configuration files. In
 fact, other than compiling with afl-clang++ and installing the resultant
 executable, no other steps are required.  In particular, there is no need to
-use the "-Dfuzz=enabled" switch in the configuration command line (although
+use the "-D fuzz=enabled" switch in the configuration command line (although
 doing so will not cause any problems).
 
 @subsection fuzzThreads Changes Required for Multi-Threaded Kea
@@ -390,7 +390,7 @@ the AFL input in the background.
 
 @subsection fuzzNotesUnitTests Unit Test Failures
 
-If unit tests are built when -Dfuzz=enabled is specified and with the AFL
+If unit tests are built when -D fuzz=enabled is specified and with the AFL
 compiler, note that tests which check or use the DHCP servers (i.e. the unit
 tests in src/bin/dhcp4, src/bin/dhcp6 and src/bin/kea-admin) will fail.
 With no AFL-related environment variables defined, a C++ exception will be

doc/devel/fuzz.dox

@@ -116,7 +116,7 @@ anything e.g. `DEBUG=true`. `unset DEBUG` to remove this behavior.
   different versions of Tsan).
 
   The simplest way to enable a sanitizer is to specify the flag on the setup
-  step with `meson setup build -Db_sanitize=thread`.
+  step with `meson setup build -D b_sanitize=thread`.
 
   When enabling lcov (code coverage), some gtest functions are detected as
   not being thread safe. It is recommended to disable lcov when enabling

doc/devel/unit-tests.dox

@@ -166,18 +166,21 @@ directly. It accepts the following command-line switches:
 Upon startup, the module loads its configuration and begins listening
 for NCRs based on that configuration.
 
-During startup, the server attempts to create a PID file of the form:
-``[runstatedir]/[conf name].kea-dhcp-ddns.pid`` where:
+During startup, the server attempts to create a PID file of the
+form: ``[pidfile_dir]/[conf name].kea-dhcp-ddns.pid`` where:
 
--  ``runstatedir`` - is the value as passed into the build configure
-   script; it defaults to "/usr/local/var/run". Note that this value may be
-   overridden at runtime by setting the environment variable
-   ``KEA_PIDFILE_DIR``. This is intended primarily for testing purposes.
+- ``pidfile_dir`` - is ``[prefix]/[localstatedir]/run/kea`` where
+  ``prefix`` and ``localstatedir`` are the values passed into meson setup using
+  ``--prefix`` and ``--localstatedir`` which default to ``/usr/local`` and
+  ``var`` respectively. So the whole ``pidfile_dir`` defaults to
+  ``/usr/local/var``. Note that this value may be overridden at runtime by
+  setting the environment variable  ``KEA_PIDFILE_DIR`` intended primarily for
+  testing purposes.
 
 -  ``conf name`` - is the configuration file name used to start the server,
    minus all preceding paths and the file extension. For example, given
-   a pathname of "/usr/local/etc/kea/myconf.txt", the portion used would
-   be "myconf".
+   a pathname of ``/usr/local/etc/kea/myconf.txt``, the portion used would
+   be ``myconf``.
 
 If the file already exists and contains the PID of a live process, the
 server issues a ``DHCP_DDNS_ALREADY_RUNNING`` log message and exits. It

doc/sphinx/arm/ddns.rst

@@ -84,18 +84,20 @@ configuration file. Since the DHCPv4 server opens privileged ports, it
 requires root access; this daemon must be run as root.
 
 During startup, the server attempts to create a PID file of the
-form: ``[runstatedir]/kea/[conf name].kea-dhcp4.pid``, where:
-
--  ``runstatedir``: The value as passed into the build configure
-   script; it defaults to ``/usr/local/var/run``. Note that this value may be
-   overridden at runtime by setting the environment variable
-   ``KEA_PIDFILE_DIR``, although this is intended primarily for testing
-   purposes.
-
--  ``conf name``: The configuration file name used to start the server,
-   minus all preceding paths and the file extension. For example, given
-   a pathname of ``/usr/local/etc/kea/myconf.txt``, the portion used would
-   be ``myconf``.
+form: ``[pidfile_dir]/[conf name].kea-dhcp4.pid`` where:
+
+- ``pidfile_dir`` - is ``[prefix]/[localstatedir]/run/kea`` where
+  ``prefix`` and ``localstatedir`` are the values passed into meson setup using
+  ``--prefix`` and ``--localstatedir`` which default to ``/usr/local`` and
+  ``var`` respectively. So the whole ``pidfile_dir`` defaults to
+  ``/usr/local/var``. Note that this value may be overridden at runtime by
+  setting the environment variable  ``KEA_PIDFILE_DIR`` intended primarily for
+  testing purposes.
+
+- ``conf name``: The configuration file name used to start the server,
+  minus all preceding paths and the file extension. For example, given
+  a pathname of ``/usr/local/etc/kea/myconf.txt``, the portion used would
+  be ``myconf``.
 
 If the file already exists and contains the PID of a live process, the
 server issues a ``DHCP4_ALREADY_RUNNING`` log message and exits. It is