Skip to content

Commit 9dfad9b

Browse files
committed
[#3770] Minor correction to hash input value.
Use non-empy delimiter. modified: ../classify.cc modified: classify_unittest.cc
1 parent 3b9c329 commit 9dfad9b

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/lib/dhcp/classify.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ ClientClasses::Hash::operator()(const ClientClasses &client_classes) {
141141

142142
size_t hash_value(const ClientClasses& client_classes) {
143143
boost::hash<std::string> hasher;
144-
return (hasher(client_classes.toText("")));
144+
return (hasher(client_classes.toText("+")));
145145
}
146146

147147
}} // end of namespace isc

src/lib/dhcp/tests/classify_unittest.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,10 +322,16 @@ TEST(ClassifyTest, ClientClassesHash) {
322322
ClientClasses cclasses2(cclasses);
323323
EXPECT_EQ(hash(cclasses2), hash(cclasses));
324324

325-
// Check that different ordering make not equal hashes.
325+
// Check that different ordering makes not equal hashes.
326326
ClientClasses cclasses3;
327327
cclasses3.insert("three");
328328
cclasses3.insert("two");
329329
cclasses3.insert("one");
330330
EXPECT_NE(hash(cclasses3), hash(cclasses));
331+
332+
// Check that single class name same as individual class names
333+
// makes not equal hashes.
334+
ClientClasses cclasses4;
335+
cclasses4.insert("onetwothree");
336+
EXPECT_NE(hash(cclasses4), hash(cclasses));
331337
}

0 commit comments

Comments
 (0)