[#1304] Checkpoint before regen (3)

Author: fxdupont

doc/examples/agent/comments.json

@@ -16,6 +16,8 @@
         {
             "comment": "basic HTTP authentication",
 
+            "type": "basic",
+
             // In basic HTTP authentication clients
             "clients":
             [

src/bin/agent/agent_lexer.ll

@@ -258,7 +258,7 @@ ControlCharacterFill            [^"\\]|\\{JSONEscapeSequence}
     case ParserContext::AUTHENTICATION:
         return AgentParser::make_REALM(driver.loc_);
     default:
-        return AgentParser::make_STRING("authentication", driver.loc_);
+        return AgentParser::make_STRING("realm", driver.loc_);
     }
 }
 

src/bin/agent/simple_parser.cc

@@ -115,7 +115,7 @@ AgentSimpleParser::parse(const CtrlAgentCfgContextPtr& ctx,
     }
 
     // Basic HTTP authentications are third.
-    ConstElementPtr auth_config = config->get("authentications");
+    ConstElementPtr auth_config = config->get("authentication");
     if (auth_config) {
         using namespace isc::http;
         BasicHttpAuthConfigPtr auth(new BasicHttpAuthConfig());

src/bin/agent/tests/testdata/get_config.json

@@ -1,15 +1,18 @@
 {
     "Control-agent": {
-        "basic-authentication-realm": "kea-control-agent",
-        "basic-authentications": [
-            {
-                "password": "1234",
-                "user": "admin",
-                "user-context": {
-                    "comment": "admin is authorized"
+        "authentication": {
+            "clients": [
+                {
+                    "password": "1234",
+                    "user": "admin",
+                    "user-context": {
+                        "comment": "admin is authorized"
+                    }
                 }
-            }
-        ],
+            ],
+            "realm": "kea-control-agent",
+            "type": "basic"
+        },
         "control-sockets": {
             "d2": {
                 "socket-name": "/tmp/kea-ddns-ctrl-socket",