|
1 | | -## 2026-02-25 — Add `__version__` attribute and fix iscc-py module docstring |
2 | | - |
3 | | -**Done:** Added `__version__` attribute to `iscc_lib` Python package via |
4 | | -`importlib.metadata.version("iscc-lib")`, fixed three incorrect module name references in |
5 | | -`crates/iscc-py/src/lib.rs` (changed `iscc._lowlevel` → `iscc_lib._lowlevel` and |
6 | | -`python/iscc/__init__.py` → `python/iscc_lib/__init__.py`), and added two tests verifying the |
7 | | -version attribute. |
8 | | - |
9 | | -**Files changed:** |
10 | | - |
11 | | -- `crates/iscc-py/python/iscc_lib/__init__.py`: Added `from importlib.metadata import version` and |
12 | | - `__version__ = version("iscc-lib")` near the top; added `"__version__"` to `__all__` |
13 | | -- `crates/iscc-py/src/lib.rs`: Fixed three references — line 1 docstring (`iscc._lowlevel` → |
14 | | - `iscc_lib._lowlevel`), line 3 (`iscc` → `iscc_lib`), line 4 path (`python/iscc/__init__.py` → |
15 | | - `python/iscc_lib/__init__.py`), and line 360 module doc (`iscc._lowlevel` → |
16 | | - `iscc_lib._lowlevel`) |
17 | | -- `tests/test_smoke.py`: Added `test_version_exists_and_correct` (verifies `__version__` is a string |
18 | | - equal to `"0.0.1"`) and `test_version_in_all` (verifies `"__version__"` is in `__all__`) |
19 | | - |
20 | | -**Verification:** All 159 Python tests pass (19 smoke + 140 conformance). |
21 | | -`python -c "import iscc_lib; print(iscc_lib.__version__)"` prints `0.0.1`. |
22 | | -`grep -q 'iscc_lib._lowlevel' crates/iscc-py/src/lib.rs` exits 0. No old incorrect `iscc._lowlevel` |
23 | | -references remain. `cargo clippy -p iscc-py -- -D warnings` clean. |
| 1 | +## 2026-02-25 — Review of: Add `__version__` attribute and fix iscc-py module docstring |
| 2 | + |
| 3 | +**Verdict:** PASS |
| 4 | + |
| 5 | +**Summary:** Clean, minimal implementation adding `__version__` via `importlib.metadata.version()` |
| 6 | +and fixing three incorrect module name references in `lib.rs`. Two `[human]`-sourced issues |
| 7 | +resolved. All 159 Python tests pass, 14 pre-commit hooks pass, clippy clean. |
| 8 | + |
| 9 | +**Verification:** |
| 10 | + |
| 11 | +- [x] `pytest tests/test_smoke.py` passes — 19 tests (17 existing + 2 new), all pass |
| 12 | +- [x] `pytest tests/` passes — 159 tests (19 smoke + 140 conformance), all pass |
| 13 | +- [x] `python -c "import iscc_lib; print(iscc_lib.__version__)"` prints `0.0.1` |
| 14 | +- [x] `grep -q 'iscc_lib._lowlevel' crates/iscc-py/src/lib.rs` exits 0 — docstring fixed |
| 15 | +- [x] `grep 'iscc\._lowlevel' ... | grep -qv 'iscc_lib'` exits non-zero — no old references remain |
| 16 | +- [x] `cargo clippy -p iscc-py -- -D warnings` clean |
| 17 | + |
| 18 | +**Issues found:** |
| 19 | + |
| 20 | +- (none) |
24 | 21 |
|
25 | 22 | **Next:** Remaining `[low]` issues: iscc-wasm conformance feature gate, iscc-wasm stale CLAUDE.md, |
26 | | -iscc-jni exception mapping, and TypeScript port evaluation. |
| 23 | +iscc-jni exception mapping, and TypeScript port evaluation. Define-next should pick the next |
| 24 | +highest-value item. |
27 | 25 |
|
28 | | -**Notes:** next.md specified the version as `"0.0.1"` which is correct for the workspace Cargo.toml |
29 | | -version. The installed package had a stale `0.1.0` version from a previous build — rebuilding with |
30 | | -`maturin develop` resolved the mismatch. Also found a third incorrect `iscc._lowlevel` reference on |
31 | | -line 360 (the `#[pymodule]` docstring) that wasn't mentioned in next.md but was caught by the |
32 | | -verification grep and fixed. |
| 26 | +**Notes:** The advance agent found and fixed a third incorrect `iscc._lowlevel` reference on line |
| 27 | +360 (the `#[pymodule]` docstring) that wasn't in next.md's scope — this was correctly caught by the |
| 28 | +verification grep and is within the spirit of the docstring fix task. Total `__all__` count is now |
| 29 | +34 symbols (33 API + `__version__`). |
0 commit comments