|
1 | | -## 2026-03-08 — Add SHA512 checksums to vcpkg portfile |
| 1 | +## 2026-03-08 — Review of: Add SHA512 checksums to vcpkg portfile |
2 | 2 |
|
3 | | -**Done:** Downloaded all 5 v0.2.0 FFI release tarballs from GitHub Releases, computed SHA512 |
4 | | -checksums for each, added `set(ISCC_SHA512 "...")` lines in each platform branch of |
5 | | -`portfile.cmake`, and replaced `SKIP_SHA512` with `SHA512 "${ISCC_SHA512}"` in the |
6 | | -`vcpkg_download_distfile` call. |
| 3 | +**Verdict:** PASS |
7 | 4 |
|
8 | | -**Files changed:** |
| 5 | +**Summary:** The advance agent replaced `SKIP_SHA512` with per-platform SHA512 checksums in |
| 6 | +`packages/cpp/portfile.cmake`. All 5 checksums were independently verified by downloading the v0.2.0 |
| 7 | +release tarballs and computing SHA512 sums — every hash matches. The change is minimal, correct, and |
| 8 | +within scope. |
9 | 9 |
|
10 | | -- `packages/cpp/portfile.cmake`: Added per-platform SHA512 checksums (5 `set()` calls) and replaced |
11 | | - `SKIP_SHA512` with `SHA512 "${ISCC_SHA512}"` in the download call |
| 10 | +**Verification:** |
12 | 11 |
|
13 | | -**Verification:** All 5 criteria pass: |
| 12 | +- [x] `SKIP_SHA512` removed from portfile — grep confirms absence |
| 13 | +- [x] `ISCC_SHA512` appears exactly 6 times (5 `set()` + 1 `SHA512` usage) |
| 14 | +- [x] `SHA512 "${ISCC_SHA512}"` pattern present in download call |
| 15 | +- [x] Each SHA512 hash is 128 lowercase hex characters — `grep -cP` returns 5 |
| 16 | +- [x] CMake syntax valid — errors on vcpkg functions (expected), not on syntax |
| 17 | +- [x] All 15 pre-commit hooks pass (`mise run check`) |
| 18 | +- [x] All 5 checksums independently verified against actual downloaded tarballs |
| 19 | +- [x] `cargo clippy --workspace --all-targets -- -D warnings` clean |
14 | 20 |
|
15 | | -- `SKIP_SHA512` no longer present in the file |
16 | | -- `ISCC_SHA512` appears exactly 6 times (5 `set()` + 1 `SHA512` usage) |
17 | | -- `SHA512 "${ISCC_SHA512}"` pattern present in download call |
18 | | -- All 5 SHA512 hashes are 128 lowercase hex characters |
19 | | -- CMake syntax is valid (errors on vcpkg functions as expected, not on syntax) |
20 | | -- All 15 pre-commit hooks pass |
| 21 | +**Issues found:** |
21 | 22 |
|
22 | | -**Next:** Only one `normal` priority issue remains: language logos in README/docs. After that, the |
23 | | -CID loop should check issues.md for any remaining items or signal idle. |
| 23 | +- (none) — clean implementation |
24 | 24 |
|
25 | | -**Notes:** The SHA512 checksums are pinned to the v0.2.0 release tarballs. Future releases will need |
26 | | -these checksums updated — the next.md explicitly noted that release workflow automation for |
27 | | -computing SHA512 on future releases is out of scope and should be a follow-up step. The Conan recipe |
28 | | -(`conanfile.py`) also lacks SHA512 verification but that's a separate concern per the scope |
29 | | -definition. |
| 25 | +**Codex review:** No actionable findings. Codex confirmed the change is limited to replacing |
| 26 | +`SKIP_SHA512` with per-platform SHA512 pins and introduces no correctness or compatibility |
| 27 | +regressions. |
| 28 | + |
| 29 | +**Next:** The only remaining `normal`-priority issue is "Add programming language logos to README |
| 30 | +and docs." After that, only `low`-priority items remain (Swift/Kotlin bindings) and the CID loop |
| 31 | +should signal idle. |
| 32 | + |
| 33 | +**Notes:** The resolved vcpkg SHA512 issue has been deleted from issues.md. The advance handoff |
| 34 | +correctly noted that future releases will need SHA512 checksums updated — this is not automated yet |
| 35 | +(explicitly out of scope per next.md). The Conan recipe (`conanfile.py`) also lacks SHA512 |
| 36 | +verification but no issue is filed for it. State.md line 135-136 still references the open issue — |
| 37 | +update-state will pick this up next cycle. |
0 commit comments