cid(review): PASS — conformance feature gate for iscc-wasm

Author: CID Agent

.claude/context/handoff.md

@@ -1,36 +1,31 @@
-## 2026-02-25 — Gate iscc-wasm `conformance_selftest` behind Cargo feature
+## 2026-02-25 — Review of: Gate iscc-wasm `conformance_selftest` behind Cargo feature
 
-**Done:** Added `conformance` Cargo feature to iscc-wasm that gates the `conformance_selftest` WASM
-export. Production WASM binaries no longer include the selftest function (and its embedded JSON
-vectors/parsing logic) unless explicitly opted in. CI workflow updated to enable the feature during
-testing.
+**Verdict:** PASS
 
-**Files changed:**
+**Summary:** Clean, minimal implementation adding a `conformance` Cargo feature to iscc-wasm that
+gates the `conformance_selftest` WASM export. All 54 wasm-pack tests pass with the feature enabled,
+CI workflow correctly updated, and no quality gate circumvention.
 
-- `crates/iscc-wasm/Cargo.toml`: added `[features]` section with `conformance = []`
-- `crates/iscc-wasm/src/lib.rs`: added `#[cfg(feature = "conformance")]` gate on
-    `conformance_selftest` export
-- `crates/iscc-wasm/tests/unit.rs`: added `#[cfg(feature = "conformance")]` gate on
-    `test_conformance_selftest_returns_true` test
-- `.github/workflows/ci.yml`: changed wasm-pack test command to
-    `wasm-pack test --node crates/iscc-wasm --features conformance`
+**Verification:**
 
-**Verification:** All 54 wasm-pack tests pass (9 conformance + 45 unit). Clippy clean. All 14
-pre-commit hooks pass. All 5 verification criteria from next.md satisfied:
+- [x] `wasm-pack test --node crates/iscc-wasm --features conformance` passes all 54 tests (9
+    conformance + 45 unit)
+- [x] `cargo clippy -p iscc-wasm -- -D warnings` clean
+- [x] `grep -q '^\[features\]' crates/iscc-wasm/Cargo.toml` exits 0 — features section exists
+- [x] `grep -q 'cfg.*feature.*conformance' crates/iscc-wasm/src/lib.rs` exits 0 — feature gate
+    present
+- [x] `grep -q '\-\-features conformance' .github/workflows/ci.yml` exits 0 — CI updated
 
-- `[x]` `wasm-pack test --node crates/iscc-wasm --features conformance` passes all 54 tests
-- `[x]` `cargo clippy -p iscc-wasm -- -D warnings` clean
-- `[x]` `grep -q '^\[features\]' crates/iscc-wasm/Cargo.toml` exits 0
-- `[x]` `grep -q 'cfg.*feature.*conformance' crates/iscc-wasm/src/lib.rs` exits 0
-- `[x]` `grep -q '\-\-features conformance' .github/workflows/ci.yml` exits 0
+**Issues found:**
+
+- (none)
 
 **Next:** Remaining `[low]` issues: iscc-wasm stale CLAUDE.md (DataHasher/InstanceHasher documented
-as unbound), iscc-jni exception mapping, and TypeScript port evaluation.
-
-**Notes:** The next.md template suggested
-`wasm-pack test --node crates/iscc-wasm -- --features conformance` (with `--` separator), but this
-is incorrect — `--` in wasm-pack passes args to the test runner binary (wasm-bindgen-test-runner),
-not to cargo. The correct syntax is `wasm-pack test --node crates/iscc-wasm --features conformance`
-(features as extra options after the path). This was discovered and fixed during implementation. The
-issue #3 in issues.md (`conformance_selftest unconditionally exported`) is now resolved by this
-change.
+as unbound), iscc-jni exception mapping, and TypeScript port evaluation. Define-next should pick the
+next highest-value item from the remaining low-priority issues.
+
+**Notes:** The advance agent correctly identified that next.md's suggested CI syntax
+`wasm-pack test --node crates/iscc-wasm -- --features conformance` (with `--` separator) is wrong —
+`--` in wasm-pack passes args to wasm-bindgen-test-runner, not to cargo. The correct form is
+`wasm-pack test --node crates/iscc-wasm --features conformance`. This is now documented in
+learnings.md. Issue #3 (`conformance_selftest unconditionally exported`) resolved and deleted.

.claude/context/issues.md

@@ -90,17 +90,6 @@ state-related errors (finalized hashers, etc.).
 
 **Source:** [human]
 
-## [low] iscc-wasm: `conformance_selftest` unconditionally exported increases binary size
-
-In `crates/iscc-wasm/src/lib.rs:197`, `conformance_selftest()` is exported via `#[wasm_bindgen]`
-without a feature gate. This pulls embedded JSON test vectors and parsing logic into every WASM
-binary, increasing bundle size for browser consumers who don't need diagnostics.
-
-Fix: gate the export behind a Cargo feature (e.g., `feature = "conformance"`) that is off by default
-for production builds.
-
-**Source:** [human]
-
 ## [low] iscc-wasm: Stale CLAUDE.md says DataHasher/InstanceHasher not yet bound
 
 In `crates/iscc-wasm/CLAUDE.md:130-131`, the documentation states "DataHasher and InstanceHasher

.claude/context/iterations.jsonl

@@ -293,3 +293,8 @@
 {"ts":"2026-02-25T07:58:01.988026+00:00","iteration":21,"role":"define-next","status":"OK","turns":20,"cost_usd":0.663946,"duration_s":128.9}
 {"ts":"2026-02-25T08:02:44.790355+00:00","iteration":21,"role":"advance","status":"OK","turns":42,"cost_usd":1.427565,"duration_s":282.8}
 {"iteration":21,"timestamp":"2026-02-25T08:10:00Z","step":"Add __version__ attribute and fix iscc-py module docstring","verdict":"PASS","files_changed":["crates/iscc-py/python/iscc_lib/__init__.py","crates/iscc-py/src/lib.rs","tests/test_smoke.py"],"issues_resolved":["iscc-py: Missing __version__ attribute","iscc-py: Module docstring references wrong package name"],"tests":{"python":159},"notes":"Standard importlib.metadata.version() pattern. 3 docstring references fixed. 2 new tests."}
+{"ts":"2026-02-25T08:06:14.269325+00:00","iteration":21,"role":"review","status":"OK","turns":32,"cost_usd":0.978825,"duration_s":209.5}
+{"ts":"2026-02-25T08:29:15.536433+00:00","iteration":22,"role":"update-state","status":"OK","turns":19,"cost_usd":0.759989,"duration_s":234.7}
+{"ts":"2026-02-25T08:32:29.540531+00:00","iteration":22,"role":"define-next","status":"OK","turns":25,"cost_usd":0.966584,"duration_s":194.0}
+{"ts":"2026-02-25T08:36:43.157615+00:00","iteration":22,"role":"advance","status":"OK","turns":38,"cost_usd":1.019102,"duration_s":253.6}
+{"iteration":22,"timestamp":"2026-02-25T08:45:00Z","step":"Gate iscc-wasm conformance_selftest behind Cargo feature","verdict":"PASS","files_changed":["crates/iscc-wasm/Cargo.toml","crates/iscc-wasm/src/lib.rs","crates/iscc-wasm/tests/unit.rs",".github/workflows/ci.yml"],"issues_resolved":["iscc-wasm: conformance_selftest unconditionally exported"],"tests":{"wasm_pack":54},"notes":"Clean minimal change. wasm-pack --features goes after path, not after --."}

.claude/context/learnings.md

@@ -119,6 +119,9 @@ Accumulated knowledge from CID iterations. Each review agent appends findings he
     Error mapping uses `JsError::new(&e.to_string())`
 - WASM crate uses `cdylib` crate-type and `publish = false` (published via npm, not crates.io) —
     same pattern as the notes/02 architecture document specifies
+- wasm-pack `--features` must go AFTER the path argument, NOT after `--`. `--` passes args to the
+    test runner (wasm-bindgen-test-runner), not to cargo. Correct:
+    `wasm-pack test --node crates/iscc-wasm --features conformance`
 - WASM crate needs `crate-type = ["cdylib", "rlib"]` (not just `cdylib`) to support integration
     tests — Rust can't link `cdylib` for the test harness. wasm-pack uses `cdylib` for packaging and
     `rlib` for test compilation. This is the standard pattern for WASM crates with tests