Skip to content

Commit 9f9d7f1

Browse files
seongsujeongLiangJYugshiroma
authored
Thermal noise Correction and EAP phase compensation (#62)
* Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * Update src/s1reader/s1_annotation.py Renaming variable for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Fix on docstring for `s1_annotation.AuxCal.load_from_zip_file()` Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Change on docstring for s1_annotation.BurstEAP._anx2height Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py updates on s1_reader.get_path_aux_cal() Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Readability improvement Co-authored-by: Liang Yu <[email protected]> * command and variable name revised for clarity * Raise error when `burst_noise` is not defined but user attempts to retrieve thermal correction LUT * fixing variable names that causing CircieCI to fail * LUT retrieval scheme changed; updates in accordance with the comments / suggestions from @Liang Yu * Changing the length unit in BurstEAP._anx2roll() to [m] * change on variable name for clarity * Addressing PEP8 issue (R0201) * Reverting the unit in `_anx2roll()` into the original documentataion; Comment cleanup * Update src/s1reader/s1_annotation.py Clarification of the description Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_annotation.py Clarification on docsctring Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_annotation.py fix on docstring Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_annotation.py unnecessary comment removed Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Docstring clarification * Addressing PEP8 C0301 * AuxCal.get_aux_cal_instrument_config_id() - check the instrument configuration id of the AUX_CAL .zip * get_path_aux_cal() - check if the instrument configuration ID matches * adding AUX_CAL files into s1-reader repository * using `os.path.join()` for `path_aux_cals` * a flag to turn on/off the EAP correction feature; revision on AUX_CAL selection algorithm * docstring update and PEP8 compliance * PEP8 compliance * Raising errors when aux_cal loader fails * PEP8 compliance * removed AuxCal.get_aux_cal_instrument_config_id() * AUX_CAL selection criteria info; early return on `get_path_aux_cal()` * Update src/s1reader/s1_reader.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * fix on AUX_CAL loader * PEP8 compliance Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]>
1 parent 315dea0 commit 9f9d7f1

13 files changed

+741
-204
lines changed
611 KB
Binary file not shown.
611 KB
Binary file not shown.
611 KB
Binary file not shown.
611 KB
Binary file not shown.
611 KB
Binary file not shown.
612 KB
Binary file not shown.
611 KB
Binary file not shown.
611 KB
Binary file not shown.
610 KB
Binary file not shown.
610 KB
Binary file not shown.

0 commit comments

Comments
 (0)