Skip to content

Commit 452f399

Browse files
gshiromaGitHub Enterprise
authored andcommitted
Quick updates to GCOV workflow parameters (#854)
* expose RTC DEM upsampling to the GCOV runconfig, set clip_min, clip_max, and rtc_min_value_db defaults to NaN * set RTC DEM upsampling default to 1
1 parent f2ae6e4 commit 452f399

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

python/packages/nisar/workflows/gcov.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def run(cfg):
6565
rtc_algorithm = rtc_dict['algorithm_type']
6666
input_terrain_radiometry = rtc_dict['input_terrain_radiometry']
6767
rtc_min_value_db = rtc_dict['rtc_min_value_db']
68+
rtc_upsampling = rtc_dict['dem_upsampling']
6869

6970
# unpack geo2rdr parameters
7071
geo2rdr_dict = cfg['processing']['geo2rdr']
@@ -291,6 +292,7 @@ def run(cfg):
291292
output_terrain_radiometry=output_terrain_radiometry,
292293
exponent=exponent,
293294
rtc_min_value_db=rtc_min_value_db,
295+
rtc_upsampling=rtc_upsampling,
294296
rtc_algorithm=rtc_algorithm,
295297
abs_cal_factor=abs_cal_factor,
296298
flag_upsample_radar_grid=flag_upsample_radar_grid,

python/packages/nisar/workflows/gcov_runconfig.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ def load(self):
2626
geocode_dict['abs_rad_cal'] = 1.0
2727

2828
if geocode_dict['clip_max'] is None:
29-
geocode_dict['clip_max'] = 5.0
29+
geocode_dict['clip_max'] = np.nan
3030

3131
if geocode_dict['clip_min'] is None:
32-
geocode_dict['clip_min'] = 0.0
32+
geocode_dict['clip_min'] = np.nan
3333

3434
if geocode_dict['geogrid_upsampling'] is None:
3535
geocode_dict['geogrid_upsampling'] = 1.0

share/nisar/defaults/gcov.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@ runconfig:
101101
input_terrain_radiometry: beta0
102102

103103
# OPTIONAL - Minimum RTC area factor in dB
104-
rtc_min_value_db: -30
104+
rtc_min_value_db:
105+
106+
# RTC DEM upsampling
107+
dem_upsampling: 1
105108

106109
# OPTIONAL - Mechanism to specify output posting and DEM
107110
geocode:
@@ -131,10 +134,10 @@ runconfig:
131134
abs_rad_cal: 1
132135

133136
# OPTIONAL - Clip values above threshold
134-
clip_max: 5.0
137+
clip_max:
135138

136139
# OPTIONAL - Clip values below threshold
137-
clip_min: 0.0
140+
clip_min:
138141

139142
# OPTIONAL - Double sampling of the radar-grid
140143
# input sampling in the range direction

share/nisar/schemas/gcov.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,9 @@ rtc_options:
172172
# Minimum RTC area factor in dB
173173
rtc_min_value_db: num(required=False)
174174

175+
# RTC DEM upsampling
176+
dem_upsampling: int(min=1, required=False)
177+
175178
geocode_options:
176179
algorithm_type: enum('area_projection', 'sinc', 'bilinear', 'bicubic', 'nearest', 'biquintic', required=False)
177180

0 commit comments

Comments
 (0)