Skip to content

Index mismatch in secret_share check of to_round_2() #7

@Nashtare

Description

@Nashtare

In the Key Generation process, part 2 step 2, the participant is checking every received commitments from other participants.
This is being done as below:

frost-dalek/src/keygen.rs

Lines 551 to 555 in 9645caf

for share in my_secret_shares.iter() {
// XXX TODO implement sorting for SecretShare and also for a new Commitment type
for (index, commitment) in self.state.their_commitments.iter() {
if index == &share.index {
share.verify(commitment)?;

However, the indices in my_secret_shares will always be equal to the current participant index, while the indices in their_commitments will be indices of the other participants (all but the one we are trying to match actually). This skips completely the share verification.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions