Skip to content

Commit 1effb29

Browse files
committed
kv: add debugging obs for TestFlowControlSendQueueRangeFeed
I haven't been able to repro this. The test has failed twice in the last couple of days, so hopefully we'll be able to see why the rangefeed isn't ending up on n3 the next time this fails. Closes cockroachdb#156064 Epic: none Release note: None
1 parent d86ed05 commit 1effb29

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

pkg/kv/kvclient/kvcoord/dist_sender_rangefeed.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ func newTransportForRange(
623623
return nil, err
624624
}
625625
replicas.OptimizeReplicaOrder(ctx, ds.st, ds.nodeIDGetter(), ds.healthFunc, ds.latencyFunc, ds.locality)
626+
log.VEventf(ctx, 2, "replica order for rangefeed transport is: %s", replicas)
626627
opts := SendOptions{class: defRangefeedConnClass}
627628
return ds.transportFactory(opts, replicas), nil
628629
}

pkg/kv/kvserver/flow_control_integration_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3220,6 +3220,7 @@ func TestFlowControlSendQueueRangeSplitMerge(t *testing.T) {
32203220
func TestFlowControlSendQueueRangeFeed(t *testing.T) {
32213221
defer leaktest.AfterTest(t)()
32223222
defer log.Scope(t).Close(t)
3223+
testutils.SetVModule(t, "dist_sender_mux_rangefeed=2,dist_sender_rangefeed=2")
32233224

32243225
// rangeFeed will create a rangefeed suitable for testing. It will start a
32253226
// rangefeed and return a function that can be used to stop it.

0 commit comments

Comments
 (0)