Merge cockroachdb#156950

156950: kvcoord: deflake TestRangeFeedMetricsManagement r=stevendanna a=pav-kv

The 10s timeout is too tight, especially in race builds. Use the `SucceedsSoon` helper instead, which defaults to 45s, or higher in race builds.

Resolves cockroachdb#156853

Co-authored-by: Pavel Kalinnikov <[email protected]>

Author: craig[bot]

pkg/kv/kvclient/kvcoord/dist_sender_rangefeed_test.go

@@ -558,12 +558,12 @@ func TestRangeFeedMetricsManagement(t *testing.T) {
 
 	// Wait for the test frontier to advance.  Once it advances,
 	// we know the rangefeed is started, all ranges are running (even if some of them are blocked).
-	testutils.SucceedsWithin(t, func() error {
+	testutils.SucceedsSoon(t, func() error {
 		if frontier.Frontier().IsEmpty() {
 			return errors.Newf("waiting for frontier advance: %s", frontier.String())
 		}
 		return nil
-	}, 10*time.Second)
+	})
 
 	// At this point, we know the rangefeed for all ranges are running.
 	require.EqualValues(t, numRanges, metrics.RangefeedRanges.Value(), frontier.String())