Merge cockroachdb#156955 cockroachdb#156969

156955: workflows: auto DR tests after a month r=jeffswenson a=msbutler

Since the artifacts will have been deleted, close out test.

Epic: none

Release note: none

156969: roachtest: disable max object count for large_schema_benchmark r=rafiss a=rafiss

This test is intentionally using a large number of tables, so we should disable the guardrail.

fixes cockroachdb#156188
fixes cockroachdb#156721

Release note: None

Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>

Author: 3 people

.github/workflows/test-failure-stale.yml

@@ -30,6 +30,6 @@ jobs:
         days-before-pr-stale: 99999
         days-before-issue-stale: 30
         days-before-close: 5
-        any-of-labels: 'T-kv,T-sql-foundations'
+        any-of-labels: 'T-kv,T-sql-foundations,T-disaster-recovery'
         only-labels: 'C-test-failure'
         exempt-issue-labels: 'release-blocker,skipped-test,X-nostale'

pkg/cmd/roachtest/tests/large_schema_benchmark.go

@@ -170,6 +170,12 @@ func registerLargeSchemaBenchmark(r registry.Registry, numTables int, isMultiReg
 						// a large number of tables
 						_, err = conn.Exec("SET CLUSTER SETTING kv.transaction.internal.max_auto_retries=500")
 						require.NoError(t, err)
+						// Disable the schema object count limit to allow creating 40,000+
+						// tables. This is a guardrail that prevents unbounded growth of the
+						// descriptor table, but for this benchmark we intentionally want to
+						// test with a large number of tables.
+						_, err = conn.Exec("SET CLUSTER SETTING sql.schema.approx_max_object_count = 0")
+						require.NoError(t, err)
 						// Create a user that will be used for authentication for the REST
 						// API calls.
 						_, err = conn.Exec("CREATE USER roachadmin password 'roacher'")