Replies: 2 comments 2 replies
-
In 0.17 I do get the identity matrix. |
Beta Was this translation helpful? Give feedback.
1 reply
-
Is your system arm64? Thinking it might be related to another GitHub issue. #6301 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This no-rotation returns a matrix full of nan-s.
I think less surprising and correct approach would be to return identity matrix - we do no-rotation on every axis, it would be somewhat more sensible result than to do the zero-rotation check on application side. Or at least the behavior might be documented.
Implementation utilizes Eigen and angle normalization which fails for null-rotation probably
Eigen::Matrix3d Geometry3D::GetRotationMatrixFromAxisAngle(
const Eigen::Vector3d& rotation) {
const double phi = rotation.norm();
return Eigen::AngleAxisd(phi, rotation / phi).toRotationMatrix();
}
Beta Was this translation helpful? Give feedback.
All reactions