Skip to content

Commit 120127e

Browse files
committed
refactor: reorganize CSS variables and improve component structure for Pagination
1 parent a932d8d commit 120127e

File tree

3 files changed

+25
-26
lines changed

3 files changed

+25
-26
lines changed
Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,45 @@
11
:root {
2-
--vc-pgn-width: 16px;
2+
--vc-pgn-active-color: var(--vc-clr-primary);
3+
--vc-pgn-background-color: var(--vc-clr-secondary);
4+
--vc-pgn-border-radius: 0;
35
--vc-pgn-height: 4px;
46
--vc-pgn-margin: 6px 5px;
5-
--vc-pgn-border-radius: 0;
6-
--vc-pgn-background-color: var(--vc-clr-secondary);
7-
--vc-pgn-active-color: var(--vc-clr-primary);
7+
--vc-pgn-width: 16px;
88
}
99

1010
.carousel__pagination {
11+
bottom: 5px;
1112
display: flex;
1213
justify-content: center;
13-
list-style: none !important;
14+
left: 50%;
1415
line-height: 0;
15-
padding: 0 !important;
16+
list-style: none !important;
1617
margin: 0 !important;
18+
padding: 0 !important;
1719
position: absolute;
18-
bottom: 5px;
19-
left: 50%;
2020
transform: translateX(-50%);
2121
}
2222

2323
.carousel__pagination-button {
24-
display: block;
24+
background: transparent;
2525
border: 0;
26-
margin: 0;
2726
cursor: pointer;
27+
display: block;
28+
margin: 0;
2829
padding: var(--vc-pgn-margin);
29-
background: transparent;
30+
}
31+
32+
.carousel__pagination-button--active::after {
33+
background-color: var(--vc-pgn-active-color);
3034
}
3135

3236
.carousel__pagination-button::after {
33-
display: block;
37+
background-color: var(--vc-pgn-background-color);
38+
border-radius: var(--vc-pgn-border-radius);
3439
content: '';
35-
width: var(--vc-pgn-width);
40+
display: block;
3641
height: var(--vc-pgn-height);
37-
border-radius: var(--vc-pgn-border-radius);
38-
background-color: var(--vc-pgn-background-color);
39-
}
40-
41-
.carousel__pagination-button--active::after {
42-
background-color: var(--vc-pgn-active-color);
42+
width: var(--vc-pgn-width);
4343
}
4444

4545
@media (hover: hover) {
@@ -48,18 +48,17 @@
4848
}
4949
}
5050

51-
5251
.carousel.is-vertical {
5352
.carousel__pagination {
53+
bottom: 50%;
54+
flex-direction: column;
5455
left: auto;
5556
right: 5px;
56-
bottom: 50%;
5757
transform: translateY(50%);
58-
flex-direction: column;
5958
}
6059

6160
.carousel__pagination-button::after {
6261
height: var(--vc-pgn-width);
6362
width: var(--vc-pgn-height);
6463
}
65-
}
64+
}

src/components/Pagination/Pagination.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { inject, h, VNode, defineComponent, computed } from 'vue'
1+
import { computed, defineComponent, h, inject, VNode } from 'vue'
22

33
import { injectCarousel } from '@/shared'
4-
import { mapNumberToRange, i18nFormatter, getSnapAlignOffset } from '@/utils'
4+
import { getSnapAlignOffset, i18nFormatter, mapNumberToRange } from '@/utils'
55

66
import { PaginationProps } from './Pagination.types'
77

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export interface PaginationProps {
1+
export type PaginationProps = {
22
disableOnClick?: boolean
33
paginateByItemsToShow?: boolean
44
}

0 commit comments

Comments
 (0)