Refactor and update classes

Author: isoguzay

app/src/main/java/com/adyen/android/assignment/di/RemoteModule.kt

@@ -4,6 +4,7 @@ import android.content.Context
 import com.adyen.android.assignment.BuildConfig
 import com.adyen.android.assignment.network.service.PlacesService
 import com.adyen.android.assignment.network.util.AppCallAdapterFactory
+import com.adyen.android.assignment.utils.Constant.NETWORK_REQUEST_TIME_OUT
 import com.google.gson.Gson
 import com.google.gson.GsonBuilder
 import dagger.Module
@@ -39,8 +40,8 @@ object RemoteModule {
             interceptorDebug.level = HttpLoggingInterceptor.Level.BODY
 
         val client = OkHttpClient.Builder()
-            .connectTimeout(20, TimeUnit.SECONDS)
-            .readTimeout(20, TimeUnit.SECONDS)
+            .connectTimeout(NETWORK_REQUEST_TIME_OUT, TimeUnit.SECONDS)
+            .readTimeout(NETWORK_REQUEST_TIME_OUT, TimeUnit.SECONDS)
             .addInterceptor { chain ->
                 val request = chain.request()
                     .newBuilder()

app/src/main/java/com/adyen/android/assignment/screens/MainActivity.kt

@@ -83,17 +83,26 @@ class MainActivity : ComponentActivity() {
         }
     }
 
+    /**
+     * cancel the cancellationTokenSource onDestroy
+     */
     override fun onDestroy() {
         super.onDestroy()
         cancellationTokenSource.cancel()
     }
 
+    /**
+     * check location permissions granted onStart
+     */
     @RequiresApi(Build.VERSION_CODES.M)
     override fun onStart() {
         super.onStart()
         getPermission()
     }
 
+    /**
+     * request permission result
+     */
     @SuppressLint("MissingSuperCall")
     override fun onRequestPermissionsResult(
         requestCode: Int,
@@ -115,6 +124,9 @@ class MainActivity : ComponentActivity() {
         }
     }
 
+    /**
+     * get location permission, if permissionState true request it again
+     */
     @RequiresApi(Build.VERSION_CODES.M)
     fun getPermission() {
         val permissionState = requestPermissionWithRationale(
@@ -126,6 +138,9 @@ class MainActivity : ComponentActivity() {
                 LocationPermissionTypes.REQUEST_AGAIN
     }
 
+    /**
+     * request current location, check the location permissions approved state
+     */
     @RequiresApi(Build.VERSION_CODES.M)
     fun locationRequestOnClick() {
         Timber.d("locationRequestOnClick()")
@@ -139,6 +154,9 @@ class MainActivity : ComponentActivity() {
         }
     }
 
+    /**
+     * request current location from location api
+     */
     @SuppressLint("MissingPermission")
     private fun requestCurrentLocation() {
         if (applicationContext.hasPermission(Manifest.permission.ACCESS_FINE_LOCATION)) {
@@ -165,8 +183,5 @@ class MainActivity : ComponentActivity() {
             }
         }
     }
-
-    companion object {
-        private const val TAG = "MainActivity"
-    }
+    
 }

app/src/main/java/com/adyen/android/assignment/utils/Constant.kt

@@ -6,5 +6,6 @@ object Constant {
     const val DUMMY_LOCATION_LAT = 52.37651 // double dummy location for Amsterdam
     const val DUMMY_LOCATION_LON = 4.90589 // double dummy location for Amsterdam
     const val REQUEST_FINE_LOCATION_PERMISSIONS_REQUEST_CODE = 34
+    const val NETWORK_REQUEST_TIME_OUT = 20L
 
 }

app/src/test/java/com/adyen/android/assignment/utils/CoroutinesTestRule.kt

@@ -8,7 +8,6 @@ import org.junit.runner.Description
 import org.junit.runners.model.Statement
 
 @ExperimentalCoroutinesApi
-
 class CoroutinesTestRule : TestRule {
 
     private val testCoroutineDispatcher = TestCoroutineDispatcher()

build.gradle

@@ -1,5 +1,3 @@
-// Top-level build file where you can add configuration options common to all sub-projects/modules.
-
 buildscript {
 
     ext.gradle_build_version = "7.0.4"
@@ -15,8 +13,6 @@ buildscript {
         classpath "com.android.tools.build:gradle:$gradle_build_version"
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
         classpath "com.google.dagger:hilt-android-gradle-plugin:$hilt_version"
-        // NOTE: Do not place your application dependencies here; they belong
-        // in the individual module build.gradle files
     }
 
 }