fix: fixes #2138 stash push/pop issue with correct stash drop and adds regression test (#2150)

* test: add regression test for stash push/pop issue (#2138)

* fix: ensure newline at end of reflog entries and correct last stash commit retrieval. fixes #2138

* fix: reverse order of stashes in list and update reflog writing logic

Author: bekatan

js/isomorphic-git/README.md

@@ -391,6 +391,7 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
     <td align="center"><a href="https://github.com/ARBhosale"><img src="https://avatars.githubusercontent.com/u/26981417?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Aniket Bhosale</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=ARBhosale" title="Code">💻</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=ARBhosale" title="Documentation">📖</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=ARBhosale" title="Tests">⚠️</a></td>
     <td align="center"><a href="https://github.com/gnillev"><img src="https://avatars.githubusercontent.com/u/8965094?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Mathias Nisted Velling</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=gnillev" title="Code">💻</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=gnillev" title="Tests">⚠️</a></td>
     <td align="center"><a href="https://github.com/acandoo"><img src="https://avatars.githubusercontent.com/u/117209328?v=4?s=60" width="60px;" alt=""/><br /><sub><b>acandoo</b></sub></a><br /><a href="#platform-acandoo" title="Packaging/porting to new platform">📦</a> <a href="#userTesting-acandoo" title="User Testing">📓</a></td>
+    <td align="center"><a href="https://github.com/bekatan"><img src="https://avatars.githubusercontent.com/u/19550476?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Bekatan Satyev</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=bekatan" title="Code">💻</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=bekatan" title="Tests">⚠️</a></td>
     <td align="center"><a href="https://github.com/hemanthkini"><img src="https://avatars.githubusercontent.com/u/3934055?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Hemanth Kini</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=hemanthkini" title="Code">💻</a></td>
   </tr>
 </table>

js/isomorphic-git/index.cjs

@@ -15179,7 +15179,11 @@ async function _stashDrop({ fs, dir, gitdir, refIdx = 0 }) {
   const stashReflogPath = stashMgr.refLogsStashPath;
   await acquireLock$1({ reflogEntries, stashReflogPath, stashMgr }, async () => {
     if (reflogEntries.length) {
-      await fs.write(stashReflogPath, reflogEntries.join('\n'), 'utf8');
+      await fs.write(
+        stashReflogPath,
+        reflogEntries.reverse().join('\n') + '\n',
+        'utf8'
+      );
       const lastStashCommit = reflogEntries[reflogEntries.length - 1].split(
         ' '
       )[1];

js/isomorphic-git/index.js

@@ -15173,7 +15173,11 @@ async function _stashDrop({ fs, dir, gitdir, refIdx = 0 }) {
   const stashReflogPath = stashMgr.refLogsStashPath;
   await acquireLock$1({ reflogEntries, stashReflogPath, stashMgr }, async () => {
     if (reflogEntries.length) {
-      await fs.write(stashReflogPath, reflogEntries.join('\n'), 'utf8');
+      await fs.write(
+        stashReflogPath,
+        reflogEntries.reverse().join('\n') + '\n',
+        'utf8'
+      );
       const lastStashCommit = reflogEntries[reflogEntries.length - 1].split(
         ' '
       )[1];