Skip to content

Commit bfe55ad

Browse files
szakariasisoos
authored andcommitted
Downloads chart: Avoid division by zero in percentage mode in the case of zero total downloads (dart-lang#8595)
1 parent 492a05e commit bfe55ad

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/web_app/lib/src/widget/downloads_chart/widget.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,9 @@ void drawChart(
356356
final List<(double, double)> lineCoordinates = <(double, double)>[];
357357
for (int week = 0; week < values.length; week++) {
358358
final value = displayMode == DisplayMode.percentage
359-
? values[week][versionRange] * 100 / totals[week]
359+
? (totals[week] == 0
360+
? 0 //Avoid division by zero, and return zero
361+
: values[week][versionRange] * 100 / totals[week])
360362
: values[week][versionRange];
361363

362364
if (displayMode == DisplayMode.unstacked) {

0 commit comments

Comments
 (0)