Merge pull request #74 from isovalent/randomise-tmp-file-name

Randomise temporary file name used in provisioner script

Author: darox

scripts/provisioner.sh

@@ -113,7 +113,8 @@ fi
 helm repo update
 
 # Substitute environment variables into the Cilium Helm values file.
-envsubst < "${CILIUM_HELM_VALUES_FILE}" > tmp1
+CILIUM_VALUES_TMP_FILE=$(mktemp)
+envsubst < "${CILIUM_HELM_VALUES_FILE}" > "${CILIUM_VALUES_TMP_FILE}"
 # Just try to wait a bit to avoid this  https://github.com/isovalent/terraform-k8s-cilium/issues/42 issue. If the file is still not available in 5 seconds, we will let helm install to throw out the error.
 sleep 5
 
@@ -122,13 +123,13 @@ then
   # Substitute environment variables into the Cilium Helm values override file.
   envsubst < "${CILIUM_HELM_VALUES_OVERRIDE_FILE}" | \
   helm upgrade --install "${CILIUM_HELM_RELEASE_NAME}" "${CILIUM_HELM_CHART}" \
-  --version "${CILIUM_HELM_VERSION}" -n "${CILIUM_NAMESPACE}" -f tmp1 -f /dev/stdin ${CILIUM_HELM_EXTRA_ARGS}
-  rm -f tmp1
+  --version "${CILIUM_HELM_VERSION}" -n "${CILIUM_NAMESPACE}" -f "${CILIUM_VALUES_TMP_FILE}" -f /dev/stdin ${CILIUM_HELM_EXTRA_ARGS}
+  rm -f "${CILIUM_VALUES_TMP_FILE}"
 else
-  envsubst < tmp1 | \
+  envsubst < "${CILIUM_VALUES_TMP_FILE}" | \
   helm upgrade --install "${CILIUM_HELM_RELEASE_NAME}" "${CILIUM_HELM_CHART}" \
   --version "${CILIUM_HELM_VERSION}" -n "${CILIUM_NAMESPACE}" -f /dev/stdin ${CILIUM_HELM_EXTRA_ARGS}
-  rm -f tmp1
+  rm -f "${CILIUM_VALUES_TMP_FILE}"
 fi