fix(deps)!: update dependencies pulling in old glob (#1612)

BREAKING CHANGE: transitive dependencies now require node 20 || >=22.

Author: bcoe

.github/workflows/ci.yaml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [18, 20]
+        node: [20, 24]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4

build-self-coverage.js

@@ -4,7 +4,7 @@ const path = require('path')
 const fs = require('fs')
 const istanbul = require('istanbul-lib-instrument')
 const makeDir = require('make-dir')
-const glob = require('glob')
+const { globSync } = require('glob')
 
 const instrumenter = istanbul.createInstrumenter({
   coverageVariable: '___NYC_SELF_COVERAGE___',
@@ -23,7 +23,7 @@ function instrumentFile (name) {
 }
 
 function instrumentGlob (pattern) {
-  const result = glob.sync(pattern, {
+  const result = globSync(pattern, {
     cwd: __dirname,
     nodir: true
   })

index.js

@@ -6,8 +6,8 @@ const cachingTransform = require('caching-transform')
 const findCacheDir = require('find-cache-dir')
 const fs = require('./lib/fs-promises')
 const os = require('os')
-const { debuglog, promisify } = require('util')
-const glob = promisify(require('glob'))
+const { debuglog } = require('util')
+const { glob } = require('glob')
 const Hash = require('./lib/hash')
 const libCoverage = require('istanbul-lib-coverage')
 const libHook = require('istanbul-lib-hook')
@@ -16,7 +16,7 @@ const mkdirp = require('make-dir')
 const Module = require('module')
 const onExit = require('signal-exit')
 const path = require('path')
-const rimraf = promisify(require('rimraf'))
+const { rimraf } = require('rimraf')
 const SourceMaps = require('./lib/source-maps')
 const TestExclude = require('test-exclude')
 const pMap = require('p-map')
@@ -240,10 +240,10 @@ class NYC {
 
       const concurrency = output ? os.cpus().length : 1
       if (this.config.completeCopy && output) {
-        const files = await glob(path.resolve(input, '**'), {
+        const files = await glob(path.resolve(input, '**').split(path.sep).join('/'), {
           dot: true,
           nodir: true,
-          ignore: ['**/.git', '**/.git/**', path.join(output, '**')]
+          ignore: ['**/.git', '**/.git/**', path.join(output, '**').split(path.sep).join('/')]
         })
         const destDirs = new Set(
           files.map(src => path.dirname(path.join(output, path.relative(input, src))))

lib/commands/instrument.js

@@ -2,9 +2,8 @@
 
 const NYC = require('../../index.js')
 const path = require('path')
-const { promisify } = require('util')
 const resolveFrom = require('resolve-from')
-const rimraf = promisify(require('rimraf'))
+const { rimraf } = require('rimraf')
 const { cliWrapper, setupOptions } = require('./helpers.js')
 
 exports.command = 'instrument <input> [output]'

npm-run-clean.js

@@ -1,8 +1,7 @@
 #!/usr/bin/env node
 'use strict'
 
-const { promisify } = require('util')
-const rimraf = promisify(require('rimraf'))
+const { rimraf } = require('rimraf')
 
 Promise.all([
   '**/.nyc_output',
@@ -16,4 +15,4 @@ Promise.all([
   'test/fixtures/cli/nyc-config-js/node_modules',
   'test/temp-dir-*',
   'self-coverage'
-].map(f => rimraf(f, { cwd: __dirname })))
+].map(f => rimraf(f, { glob: { cwd: __dirname } })))