additions to tests definitions

Author: istefanis

README.md

@@ -90,7 +90,7 @@ A User Guide is included in the web app, and can be launched from the main menu
 
 4. Run `npm test` to execute the tests via [Jest](https://jestjs.io/)
 
-> _Current test coverage according to Jest: 62% (statements)_
+> _Current test coverage according to Jest: 67% (statements)_
 
 ## Code Structure
 

test/definitions/plotsTests.js

@@ -14,6 +14,7 @@ import {
 } from "../../util/commons.js";
 import BodePlot from "../../view/plots/bodePlot.js";
 import NyquistPlot from "../../view/plots/nyquistPlot.js";
+import TimeDomainPlot from "../../view/plots/timeDomainPlot.js";
 
 const bodeSteps = (numeratorTermsArray, denominatorTermsArray) => {
   const { magnitudeCurvePoints, phaseCurvePoints, characteristicNumbers } =
@@ -38,13 +39,31 @@ const nyquistSteps = (numeratorTermsArray, denominatorTermsArray) => {
   return [curvePoints, stability];
 };
 
+const timeDomainSteps = (numeratorTermsArray, denominatorTermsArray) => {
+  const { timeResponseCurvePoints, trajectoryCurvePoints } = new TimeDomainPlot(
+    null,
+    numeratorTermsArray,
+    denominatorTermsArray,
+    findComplexRootsOfPolynomial(numeratorTermsArray),
+    findComplexRootsOfPolynomial(denominatorTermsArray)
+  );
+  return [timeResponseCurvePoints, trajectoryCurvePoints];
+};
+
 const bodeAndNyquistSteps = (numeratorTermsArray, denominatorTermsArray) => {
   return [
     ...bodeSteps(numeratorTermsArray, denominatorTermsArray),
     ...nyquistSteps(numeratorTermsArray, denominatorTermsArray),
   ];
 };
 
+const bodeAndTimeDomainSteps = (numeratorTermsArray, denominatorTermsArray) => {
+  return [
+    ...bodeSteps(numeratorTermsArray, denominatorTermsArray),
+    ...timeDomainSteps(numeratorTermsArray, denominatorTermsArray),
+  ];
+};
+
 export const plotsTests = {
   test1: {
     description: "test1: tf([1, 0, 0, 0], [1])",
@@ -158,11 +177,13 @@ export const plotsTests = {
     description: "test4: tf([1], [1, 0, 1])",
     numeratorTermsArray: [1],
     denominatorTermsArray: [1, 0, 1],
-    steps: bodeSteps,
+    steps: bodeAndTimeDomainSteps,
     assertions: (
       magnitudeCurvePoints,
       phaseCurvePoints,
-      characteristicNumbers
+      characteristicNumbers,
+      timeResponseCurvePoints,
+      trajectoryCurvePoints
     ) => [
       [
         "Roll-off",
@@ -176,6 +197,18 @@ export const plotsTests = {
         "-180",
         toleranceTestsSmall,
       ],
+      [
+        "Max f(t)",
+        Math.max(...timeResponseCurvePoints.map((x) => x[1])),
+        1,
+        toleranceTestsSmall,
+      ],
+      [
+        "Min f(t)",
+        Math.min(...timeResponseCurvePoints.map((x) => x[1])),
+        -1,
+        toleranceTestsSmall,
+      ],
     ],
   },
 

test/definitions/viewServicesTests.js

@@ -10,8 +10,10 @@ import { Block } from "../../model/elements/block.js";
 import { getTopBlock, setTopBlock } from "../../model/topBlockService.js";
 import { roundDecimal, sleep } from "../../util/commons.js";
 import { setLogMode } from "../../util/loggingService.js";
+import { domElements } from "../../view/services/core/elementRenderingService.js";
 import { getTotalLengthOfAllLines } from "../../view/services/core/lineRenderingService.js";
 import { optimizeTopology } from "../../view/services/feature/optimizeTopologyService.js";
+import { openOrUpdateElementAnalysisWindow } from "../../view/elementAnalysisWindowView.js";
 import { circuit1 } from "./circuits.js";
 
 export const viewServicesTests = {
@@ -131,4 +133,37 @@ export const viewServicesTests = {
     assertion: (x) => x,
     resultsDescription: () => "traversed successfully",
   },
+
+  test4: {
+    description: "test4: elementAnalysisWindowView",
+    steps: async function () {
+      if (getTopBlock()) {
+        getTopBlock().clearState();
+      } else {
+        setTopBlock(new Block());
+      }
+      setTopBlock(circuit1(getTopBlock()));
+
+      openOrUpdateElementAnalysisWindow(domElements[0]);
+
+      for (let i = 1; i <= 3; i++) {
+        const elementAnalysisWindowTabButton = document.getElementById(
+          `element-analysis-window-tab-button-${i}`
+        );
+        elementAnalysisWindowTabButton.click();
+        await sleep(500);
+      }
+
+      const elementAnalysisWindowCloseButton = document.getElementById(
+        `element-analysis-window-close-button`
+      );
+      elementAnalysisWindowCloseButton.click();
+
+      getTopBlock().clearState();
+
+      return [true];
+    },
+    assertion: (x) => x,
+    resultsDescription: () => "traversed successfully",
+  },
 };